Re: [Bluez-devel] [PATCH] Make device selection look better

[Bastien Nocera <hadess@hadess.net>]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]


On Tue, 2008-01-29 at 18:03 +0100, Marcel Holtmann wrote:
> Hi Bastien,
> 
> > > Here's a patch to make the device selection widget look better, from the
> > > bug http://bugzilla.gnome.org/show_bug.cgi?id=505222
> > > 
> > > Before:
> > > http://bugzilla.gnome.org/attachment.cgi?id=103695&action=view
> > > After:
> > > http://bugzilla.gnome.org/attachment.cgi?id=103696&action=view
> > 
> > Updated patch with some fixes:
> > http://bugzilla.gnome.org/show_bug.cgi?id=505222#c18
> 
> patch has been applied. Please check bluetooth-applet and make sure its
> usage of the device selector is correct and HIG compliant.

Patch attached.

[-- Attachment #2: bluez-gnome-fix-browse-dialogue.patch --]
[-- Type: text/x-patch, Size: 789 bytes --]

Index: main.c
===================================================================
RCS file: /cvsroot/bluez/gnome/applet/main.c,v
retrieving revision 1.96
diff -u -p -r1.96 main.c
--- main.c	16 Jan 2008 15:41:03 -0000	1.96
+++ main.c	1 Feb 2008 12:49:50 -0000
@@ -1620,9 +1620,11 @@ static void browse_callback(GObject *wid
 
 	gtk_window_set_default_size(GTK_WINDOW(dialog), 450, 360);
 
-	gtk_container_set_border_width(GTK_CONTAINER(dialog), 6);
+	gtk_container_set_border_width (GTK_CONTAINER (dialog), 5);
+	gtk_box_set_spacing (GTK_BOX (GTK_DIALOG (dialog)->vbox), 2);
 
 	selector = bluetooth_device_selection_new(_("Select device to browse"));
+	gtk_container_set_border_width(GTK_CONTAINER(selector), 5);
 
 	gtk_container_add(GTK_CONTAINER(GTK_DIALOG(dialog)->vbox), selector);
 

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel