From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marcel Holtmann To: BlueZ development In-Reply-To: <1202346828.3491.47.camel@cookie.hadess.net> References: <1201887887.2389.346.camel@cookie.hadess.net> <1202305613.3491.36.camel@cookie.hadess.net> <1202346828.3491.47.camel@cookie.hadess.net> Date: Sun, 10 Feb 2008 02:21:04 +0100 Message-Id: <1202606464.7664.27.camel@violet> Mime-Version: 1.0 Subject: Re: [Bluez-devel] [PATCH] Split agents Reply-To: BlueZ development List-Id: BlueZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Sender: bluez-devel-bounces@lists.sourceforge.net Errors-To: bluez-devel-bounces@lists.sourceforge.net Hi Bastien, > > > First draft patch to split the agents away from the main program. Seems > > > to work fine for me. > > > > > > This is mostly moving functions around though. > > > > Updated patch following the comments from Marcel. > > Patch that compiles again. I like the split of the notifications. Can we do that first in a separate patch. Looks simple enough and makes the history a lot cleaner compared to a big one. Three small things with it: * Please use notify.[ch] as filename. I don't like too long file names. * No need to include . No translations in this file. * I saw some whitespaces and empty line things mistakes. Regards Marcel ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel