public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Guillaume Bedot <littletux@zarb.org>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [Bluez-devel] forcing SCO connection patch
Date: Wed, 27 Feb 2008 14:04:42 +0100	[thread overview]
Message-ID: <1204117482.6889.37.camel@localhost> (raw)
In-Reply-To: <47C555E5.2000903@mizi.com>

Re,

Le mercredi 27 février 2008 à 21:21 +0900, Louis JANG a écrit :
>  	conn = hci_conn_hash_lookup_ba(hdev, ev->link_type, &ev->bdaddr);
> -	if (!conn)
> -		goto unlock;
> +	if (!conn) {
> +		__u8 link_type = (ev->link_type == ESCO_LINK) ? SCO_LINK : ESCO_LINK;
> +
> +		conn = hci_conn_hash_lookup_ba(hdev, link_type, &ev->bdaddr);
> +		if (!conn)
> +			goto unlock;

Does your patch handle re-negotiation of the SCO link back to an eSCO
one ? Great.

And the style in your patch is better according to Marcel rules.

I vote for yours.

Best regards,

Guillaume B.


  parent reply	other threads:[~2008-02-27 13:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17 12:39 [Bluez-devel] forcing SCO connection patch Louis JANG
2008-02-25  6:43 ` Brad Midgley
2008-02-25  6:56   ` Brad Midgley
2008-02-26 19:19   ` Guillaume Bedot
2008-02-26 19:28     ` Marcel Holtmann
2008-02-26 21:05       ` Guillaume Bedot
     [not found] ` <a8e1da0802242330l765b8b1ava62b857baf8a5568@mail.gmail.com>
     [not found]   ` <47C28A33.4070102@mizi.com>
     [not found]     ` <a8e1da0802250155u1b7af481va203849f68d9106b@mail.gmail.com>
     [not found]       ` <47C2A7FA.2060902@mizi.com>
     [not found]         ` <70692DDF-93B7-447E-ABEE-3CDBD94F15F1@holtmann.org>
     [not found]           ` <47C38D40.3040809@mizi.com>
     [not found]             ` <B96BD3FE-F490-4AD5-9315-ECD42CE9C728@holtmann.org>
     [not found]               ` <47C4C3D4.8010902@mizi.com>
     [not found]                 ` <2A7EF87C-1340-45D7-B457-F81799674B1E@holtmann.org>
     [not found]                   ` <47C555E5.2000903@mizi.com>
2008-02-27 13:04                     ` Guillaume Bedot [this message]
     [not found]                     ` <5D9353FF-6A69-4039-9033-C0EBD1CDA756@holtmann.org>
     [not found]                       ` <47C62147.90007@mizi.com>
2008-02-28 10:57                         ` Guillaume Bedot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204117482.6889.37.camel@localhost \
    --to=littletux@zarb.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox