Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: Arman Uguray <armansito@chromium.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] core: Reduce RSSI delta threshold for RSSI property updates on Device1.
Date: Tue, 30 Sep 2014 10:34:40 +0200	[thread overview]
Message-ID: <12072518.xz8sZz3RZr@uw000953> (raw)
In-Reply-To: <1412028964-5298-1-git-send-email-armansito@chromium.org>

Hi Arman,

On Monday 29 of September 2014 15:16:04 Arman Uguray wrote:
> Currently the daemon does not update the RSSI property of a device object unless
> it sees a change of at least 8 dBm. This is too large for proximity use cases
> involving changes in distance within 4-5 feet. This patch reduces the threshold
> to 2 dBm to address this.
> ---
>  src/device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/device.c b/src/device.c
> index 875a5c5..821549e 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -4094,8 +4094,8 @@ void device_set_rssi(struct btd_device *device, int8_t rssi)
>  		else
>  			delta = rssi - device->rssi;
>  
> -		/* only report changes of 8 dBm or more */
> -		if (delta < 8)
> +		/* only report changes of 2 dBm or more */
> +		if (delta < 2)
>  			return;

I'm not sure if having this so small is good... ie those few devices I have
they tend to have ~4 dBm RSSI oscillation when just lying next to each other
on the desk.
  
>  		DBG("rssi %d delta %d", rssi, delta);
> 

-- 
Best regards, 
Szymon Janc

  reply	other threads:[~2014-09-30  8:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-29 22:16 [PATCH BlueZ] core: Reduce RSSI delta threshold for RSSI property updates on Device1 Arman Uguray
2014-09-30  8:34 ` Szymon Janc [this message]
2014-09-30 16:58   ` Arman Uguray
2014-09-30 17:04     ` Marcel Holtmann
2014-09-30 17:21       ` Arman Uguray
2014-09-30 17:26         ` Marcel Holtmann
2014-10-01 15:32           ` Arman Uguray
2014-10-02  8:34             ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12072518.xz8sZz3RZr@uw000953 \
    --to=szymon.janc@tieto.com \
    --cc=armansito@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox