public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] [BlueZ-Announce] Release of bluez-gnome-0.26
Date: Fri, 11 Apr 2008 12:31:46 +0200	[thread overview]
Message-ID: <1207909906.1098.2.camel@californication> (raw)
In-Reply-To: <1207672137.3396.52.camel@cookie.hadess.net>

Hi Bastien,

> Another patch. This one gives you a better error message when you have a
> Palm device, as well as changing the "ETA" message to match that of
> Nautilus.

the patch has been committed, but in a total different form. Can I just
remind you to comply with the coding style (aka whitespaces) and please
don't do such complex code.

if () if () if () makes my brain hurt. I prefer if (!) return etc. A
good rule is that if a line hits the 80 characters marker, then the code
is too complex.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

      reply	other threads:[~2008-04-11 10:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1207446435.26353.1.camel@californication>
2008-04-08 16:28 ` [Bluez-devel] [BlueZ-Announce] Release of bluez-gnome-0.26 Bastien Nocera
2008-04-11 10:31   ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207909906.1098.2.camel@californication \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox