From: Marcel Holtmann <marcel@holtmann.org>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Maxim Krasnyansky <maxk@qualcomm.com>,
Dave Young <hidave.darkstar@gmail.com>,
Soeren Sonnenburg <kernel@nn7.de>,
David Woodhouse <dwmw2@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: fix oops in rfcomm tty code (v2)
Date: Sat, 19 Jul 2008 23:38:20 +0200 [thread overview]
Message-ID: <1216503500.8411.110.camel@violet.holtmann.net> (raw)
In-Reply-To: <20080719211227.GA14173@localhost.localdomain>
Hi Vegard,
> This is a resend of a patch I sent earlier. It fixes a reproducible
> oops (see http://lkml.org/lkml/2008/7/13/89 for test case), and I'd
> be very happy for some feedback from Bluetooth people. Can this be
> included for testing somewhere? I don't have any bluetooth devices
> myself, so all my testing is limited to creating/releasing devices
> with ioctl (I'm not sure that's good enough).
>
> Dave: I have extended the rfcomm_dev_lock to include all the setup and
> teardown of a single device. On second thought, it doesn't really make
> sense to use a separate lock for that. May I have your opinion on this
> second version? (I've fixed the comments/BUG_ON that you pointed out.)
it seems it is the actually the first time, I see this one. Anyway, so
holding that lock is a bad idea. Fixing this the right way might be
tricky since the TTY layer is involved here and own the kobject. So I
would say we have to make sure that the RFCOMM TTY will hangup when
calling RELEASEDEV or otherwise fail.
Regards
Marcel
next prev parent reply other threads:[~2008-07-19 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-19 21:12 [PATCH] Bluetooth: fix oops in rfcomm tty code (v2) Vegard Nossum
2008-07-19 21:38 ` Marcel Holtmann [this message]
2008-07-21 6:51 ` Vegard Nossum
2008-07-21 10:31 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216503500.8411.110.camel@violet.holtmann.net \
--to=marcel@holtmann.org \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=hidave.darkstar@gmail.com \
--cc=kernel@nn7.de \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox