public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Ben Collins <ben.collins@canonical.com>
Cc: linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices
Date: Mon, 21 Jul 2008 07:08:11 +0200	[thread overview]
Message-ID: <1216616891.8411.114.camel@violet.holtmann.net> (raw)
In-Reply-To: <E1KKl4I-00068H-S6@swissweb.swissdisk.com>

Hi Ben,

> When the Dell 370 and 410 BT adapters are put into BT radio mode, they
> need to be prepared like many other Broadcom adapters.
> 
> Also, add quirk Broadcom 2046 devices with HCI_RESET.
> 
> CC: linux-bluetooth@vger.kernel.org
> Signed-off-by: Michael Frey <michael.frey@canonical.com>
> Signed-off-by: Mario Limonciello <Mario_Limonciello@Dell.com>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> Signed-off-by: Ben Collins <ben.collins@canonical.com>
> ---
>  drivers/bluetooth/hci_usb.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/bluetooth/hci_usb.c b/drivers/bluetooth/hci_usb.c
> index 192522e..0254a6b 100644
> --- a/drivers/bluetooth/hci_usb.c
> +++ b/drivers/bluetooth/hci_usb.c
> @@ -134,6 +134,13 @@ static struct usb_device_id blacklist_ids[] = {
>  
>  	/* Dell laptop with Broadcom chip */
>  	{ USB_DEVICE(0x413c, 0x8126), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
> +	/* Dell Wireless 370 */
> +	{ USB_DEVICE(0x413c, 0x8156), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
> +	/* Dell Wireless 410 */
> +	{ USB_DEVICE(0x413c, 0x8152), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
> +        
> +        /* Broadcom 2046 */
> +        { USB_DEVICE(0x0a5c, 0x2151), .driver_info = HCI_RESET },

do me a favor and use tabs and not whitespaces here. And is this the
latest Apple machine that has a Broadcom instead of a CSR chip in it. If
so, then let the comment reflect this.

Regards

Marcel



  reply	other threads:[~2008-07-21  5:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <24762.90.138.930.038.1036103001.ben.collins@canonical.com>
2008-07-21  1:45 ` [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices Ben Collins
2008-07-21  5:08   ` Marcel Holtmann [this message]
2008-07-21  5:54     ` Ben Collins
2008-07-21 16:00     ` Ben Collins
2008-07-21 23:30       ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216616891.8411.114.camel@violet.holtmann.net \
    --to=marcel@holtmann.org \
    --cc=ben.collins@canonical.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox