public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: linux-pcmcia@lists.infradead.org, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 04/39] pcmcia: use pcmcia_loop_config in bluetooth drivers
Date: Mon, 18 Aug 2008 21:57:11 +0200	[thread overview]
Message-ID: <1219089431.7591.66.camel@violet.holtmann.net> (raw)
In-Reply-To: <1219085610-12289-4-git-send-email-linux@dominikbrodowski.net>

Hi Dominik,

> Use the config loop helper in bluetooth pcmcia drivers.
> 
> CC: Marcel Holtmann <marcel@holtmann.org>
> CC: linux-bluetooth@vger.kernel.org
> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>

I know that the Bluetooth PCMCIA drivers are not the best examples for
coding style, but please double check your whitespaces/tabs. We don't
wanna make it worse.

> -	return get_tuple(handle, tuple, parse);
> +        unsigned long try = (unsigned long) priv_data;
> +
> +       if (cf->vpp1.present & (1 << CISTPL_POWER_VNOM))
> +               p_dev->conf.Vpp = cf->vpp1.param[CISTPL_POWER_VNOM] / 10000;

This is an obvious case where something is wrong.

Regards

Marcel



  reply	other threads:[~2008-08-18 19:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080818185025.GA11647@comet.dominikbrodowski.net>
2008-08-18 18:52 ` [PATCH 04/39] pcmcia: use pcmcia_loop_config in bluetooth drivers Dominik Brodowski
2008-08-18 19:57   ` Marcel Holtmann [this message]
2008-08-18 20:27     ` Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219089431.7591.66.camel@violet.holtmann.net \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=linux@dominikbrodowski.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox