public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Oliver Neukum <oliver@neukum.org>,
	Stefan Seyfried <seife@suse.de>,
	linux-pm@lists.linux-foundation.org,
	linux-bluetooth@vger.kernel.org, Pavel Machek <pavel@suse.cz>,
	linux-usb@vger.kernel.org
Subject: Re: btusb hibernation/suspend breakage in current -git
Date: Wed, 27 Aug 2008 11:56:44 +0200	[thread overview]
Message-ID: <1219831004.19009.2.camel@californication> (raw)
In-Reply-To: <200808270128.16052.rjw@sisk.pl>

Hi Rafael,

> > > > > > Good. Can you test what happens if you unplug the device while suspended
> > > > > > and hibernated?
> > > > > 
> > > > > It's built-in, I can't unplug it. :-)
> > > > 
> > > > Maybe you can disable it in the BIOS, but this might change the DSDT / other
> > > > system configuration, so it might break resume in other ways :-(
> > > 
> > > There is a switch that's supposed to disable the radio (rfkill or something).
> > > I used it to switch the radio off while the box was waking up from hibernation
> > > and kbluetooth didn't find the adapter after the resume.  After I've pressed
> > > the "radio off" button again, the bluetooth appears to be functional again.
> > > 
> > > However, this "radio off" button is shared between bluetooth and wireless
> > > (b43) and there are some surprising interactions.  Nothing seems to be broken,
> > > though.
> > 
> > This doesn't explain the original failure. Can you comment out the support
> > for suspend/resume in the driver and try again?
> 
> With that commented out, I'm able to reproduce the failure.  With the original
> patch, I'm not.

I've never seen any issues with the suspend/resume and btusb, but I
must admit that I am using an X61 and in that case pm-utils has a magic
hack to disable Bluetooth before suspend and this means a clean
disconnect from the USB bus.

Anyway, killing all URBs in-fly on suspend and bringing up the interrupt
one on resume should do the right thing. However we have to check if we
not just better resume all URBs and let the Bluetooth core handle lost
connection during the suspended time.

Regards

Marcel



      parent reply	other threads:[~2008-08-27  9:56 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-22 13:20 [rft]autosuspend for btusb Oliver Neukum
2008-08-22 13:33 ` Marcel Holtmann
2008-08-22 13:51   ` Oliver Neukum
2008-08-22 14:31     ` Marcel Holtmann
2008-08-22 14:38       ` Oliver Neukum
2008-08-25 10:43       ` Oliver Neukum
2008-08-25 11:51         ` Marcel Holtmann
2009-02-11 16:52           ` [linux-pm] " Matthew Garrett
2009-02-11 16:55             ` Marcel Holtmann
2008-08-26  9:56         ` Pavel Machek
2008-08-26 10:05           ` Pavel Machek
2008-08-26 11:02             ` Oliver Neukum
2008-08-28  8:06               ` Pavel Machek
2008-08-25 11:37       ` btusb hibernation/suspend breakage in current -git Rafael J. Wysocki
2008-08-25 11:53         ` Oliver Neukum
2008-08-25 11:55           ` Marcel Holtmann
2008-08-25 12:45         ` Pavel Machek
     [not found]         ` <BEF46EAA-4013-44BB-881F-F1740FE8BE6D@holtmann.org>
2008-08-25 13:50           ` Oliver Neukum
2008-08-26  9:36             ` Rafael J. Wysocki
2008-08-26  9:43               ` Oliver Neukum
2008-08-26 10:10                 ` Rafael J. Wysocki
2008-08-26 11:41                   ` Stefan Seyfried
2008-08-26 18:44                     ` Rafael J. Wysocki
2008-08-26 19:53                       ` Oliver Neukum
2008-08-26 23:28                         ` Rafael J. Wysocki
2008-08-27  7:55                           ` Oliver Neukum
2008-08-27 13:04                             ` Rafael J. Wysocki
2008-08-27 13:09                               ` Oliver Neukum
2008-08-27 13:28                                 ` Rafael J. Wysocki
2008-08-27 22:33                                   ` [linux-pm] " Rafael J. Wysocki
2008-08-28  7:17                                     ` Oliver Neukum
2008-09-08 20:49                                       ` Marcel Holtmann
2008-09-08 21:45                                         ` Rafael J. Wysocki
     [not found]                           ` <5E249C07-0710-49B2-B352-87DDA85E891D@holtmann.org>
2008-08-27  9:10                             ` Pavel Machek
2008-08-27 13:29                               ` Rafael J. Wysocki
2008-08-27  9:56                           ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219831004.19009.2.camel@californication \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=pavel@suse.cz \
    --cc=rjw@sisk.pl \
    --cc=seife@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox