public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] [PATCH] Advertise Telephony service class when	device offers headset AG or handsfree AG
Date: Sat, 30 Aug 2008 10:58:42 +0200	[thread overview]
Message-ID: <1220086722.7145.33.camel@californication> (raw)
In-Reply-To: <1220050803-30362-1-git-send-email-npelly@google.com>

Hi Nick,

>  src/sdpd-service.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/src/sdpd-service.c b/src/sdpd-service.c
> index cf120b8..df9017e 100644
> --- a/src/sdpd-service.c
> +++ b/src/sdpd-service.c
> @@ -125,6 +125,8 @@ static void update_svclass_list(void)
>  		case INTERCOM_SVCLASS_ID:
>  		case FAX_SVCLASS_ID:
>  		case SAP_SVCLASS_ID:
> +		case HEADSET_AGW_SVCLASS_ID:
> +		case HANDSFREE_AGW_SVCLASS_ID:
>  			val |= 0x40;	/* Telephony */
>  			break;
>  		case AUDIO_SOURCE_SVCLASS_ID:

do you have a reference to a spec. for this one. The automatic service
class adjustment has been done according to the spec. I could have
missed one or two, but I am quite sure I didn't. So while it looks okay,
we have to make sure that we didn't violate the specs.

Regards

Marcel



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2008-08-30  8:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29 23:00 [Bluez-devel] [PATCH] Advertise Telephony service class when device offers headset AG or handsfree AG Nick Pelly
2008-08-30  8:58 ` Marcel Holtmann [this message]
2008-08-30  7:16   ` Nick Pelly
2008-08-30  9:28     ` Marcel Holtmann
2008-08-30  7:37       ` Nick Pelly
2008-08-30 10:04         ` Marcel Holtmann
2008-08-30  8:32           ` Nick Pelly
2008-08-30 10:46             ` Marcel Holtmann
2008-09-01  7:46             ` Nick Pelly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1220086722.7145.33.camel@californication \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox