Re: [Bluez-devel] Sniff mode issues regarding Sony Ericsson headsets: kernel patch proposal.

Marcel Holtmann
2008-09-14T09:22:51Z

Hi Fabien,

> >> Here are patches against 2.6.27-rc6 and latest bluez git that add
> >> support for point 1 below.
> >
> > problem with these patches is that they are a layer violation between
> > L2CAP and HCI.
>
> Yes that is true but that is nothing that isn't already existing. Same
> trick is used for L2CAP_CONNINFO.

no they don't. Look at the code. It is nicely abstracted on how we
handle the two layers.

> > It should also work on incoming and outgoing connections
> > the same way.
>
> I'm not following you there...

We wanna be able to set this on a server socket and also enforce it on a
connection we created.

> > Also when using socket options, I prefer that we set them
> > and store the value and the execute it once the connections is up.
>
> Agreed. I was just too lazy to do that :-)

Lazy doesn't get it upstream :)

> > Personally I prefer if we would enhance hci_send_acl() to indicate that
> > we expect it got get out of any power state before processing this data
> > packet.
> >
> > And of course this socket option also has to work for RFCOMM.
>
> That's pretty much useless as i don't know if that will ever get used.
> However that's not much work, i can do it if that makes you happy. ;-)

I treat RFCOMM and L2CAP the same. If we implement something for one
protocol, we do have to do the same for the other.

> Do you have any comments on the user-land side or is it how you see things ?

Actually I do have to figure out the exact naming, but it is basically
set this option once approach. And the kernel will do the rest.

Regards

Marcel

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net