From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] [patch] BNEP/PAN Qualification issues
Date: Mon, 08 Sep 2008 11:32:14 +0200 [thread overview]
Message-ID: <1220866334.6714.142.camel@californication> (raw)
In-Reply-To: <48C4E8E6.7090906@access-company.com>
Hi Frederic,
> Great you could start integrating.
> Please find attached the remaining patches.
the 0001 patch contains an extra setup variable that is not used in the
patch at all. Remove it from it.
The 0002 patch mixes the non-understood changes with the setup changes.
Also can we just use flags variable in the session instead of setup. The
UUID handling could be done a little bit more elegant.
What is the point behind 0003 patch?
I think 0004 patch needs some cleanup. It looks too hackish.
The 0006 patch is not how we handle this. Either use the exported
version number of the BNEP module or we have to add an ioctl for it.
Please don't hijack a thread for this and send these patches one by one
to linux-bluetooth@vger.kernel.org.
Regards
Marcel
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
prev parent reply other threads:[~2008-09-08 9:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 14:15 [Bluez-devel] [patch] BNEP/PAN Qualification issues Frédéric Dalleau
2008-04-17 18:17 ` Luiz Augusto von Dentz
2008-04-17 18:26 ` Marcel Holtmann
2008-04-17 20:42 ` Claudio Takahasi
2008-04-24 17:42 ` Marcel Holtmann
2008-05-22 11:01 ` Frédéric Dalleau
2008-05-22 11:48 ` Marcel Holtmann
2008-05-22 14:05 ` Frédéric Dalleau
2008-07-01 17:04 ` Frédéric Dalleau
2008-07-17 9:44 ` Frédéric Dalleau
2008-07-19 15:14 ` Luiz Augusto von Dentz
2008-08-07 22:34 ` Marcel Holtmann
2008-09-08 8:57 ` Frédéric Dalleau
2008-09-08 9:32 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220866334.6714.142.camel@californication \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox