public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Pelly <npelly@google.com>
To: linux-bluetooth@vger.kernel.org
Cc: Nick Pelly <npelly@google.com>
Subject: [PATCH] Advertise telephony service class for handsfree AG role, for Nokia 616 support.
Date: Tue, 23 Sep 2008 11:19:44 -0700	[thread overview]
Message-ID: <1222193984-27820-1-git-send-email-npelly@google.com> (raw)

The Nokia 616 incorrectly requires the telehony bit to be set to make a
handsfree connection.
---
 src/sdpd-service.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/sdpd-service.c b/src/sdpd-service.c
index 30aad32..f138d22 100644
--- a/src/sdpd-service.c
+++ b/src/sdpd-service.c
@@ -121,6 +121,13 @@ static void update_svclass_list(void)
 		case HANDSFREE_SVCLASS_ID:
 			val |= 0x20;	/* Audio */
 			break;
+		/* For Nokia 616 carkit compatability - it incorrectly requires
+		 * the telephony bit set for handsfree usage, despite this not
+		 * being a requirement of the handsfree spec.
+		 */
+		case HANDSFREE_SVCLASS_ID:
+			val |= 0x40;    /* Telephony */
+			break;
 		case CORDLESS_TELEPHONY_SVCLASS_ID:
 		case INTERCOM_SVCLASS_ID:
 		case FAX_SVCLASS_ID:
-- 
1.5.5


             reply	other threads:[~2008-09-23 18:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-23 18:19 Nick Pelly [this message]
2008-09-23 18:25 ` [PATCH] Advertise telephony service class for handsfree AG role, for Nokia 616 support Nick Pelly
2008-09-23 18:29   ` Nick Pelly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1222193984-27820-1-git-send-email-npelly@google.com \
    --to=npelly@google.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox