From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Fix PS3 BD remote input event generation
Date: Tue, 14 Oct 2008 12:09:58 +0200 [thread overview]
Message-ID: <1223978998.4764.3.camel@californication> (raw)
In-Reply-To: <8D4D4D94-FD26-47A8-A9F9-CFD7D093BBDE@gmail.com>
Hi Johan,
> > - Fix byte-reading in the decode function by using a guint8, instead
> > of an int, we were overreading and were getting keycodes of
> > 0xffffff44 when we wanted a single byte of 0x44.
> > - Remove use of KEY_REMOTE_X, those keys never got upstream, and the
> > values they were defined at are now used for completely different
> > keys
> > - Update uinput.h with the latest keycodes from 2.6.27
>
> The patch has been pushed upstream. Thanks!
this patch should have been split at least into 2 pieces (maybe 3). The
uinput update at least should have been separate. We are using GIT and
there is no reason to push combined patches ever. I do _NOT_ wanna have
big patches that fix multiple things. Break them down.
Regards
Marcel
prev parent reply other threads:[~2008-10-14 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 22:28 [PATCH] Fix PS3 BD remote input event generation Bastien Nocera
2008-10-14 6:38 ` Johan Hedberg
2008-10-14 10:09 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223978998.4764.3.camel@californication \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox