From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4900A74C.5030200@dell.com> Date: Thu, 23 Oct 2008 11:33:16 -0500 From: Mario Limonciello MIME-Version: 1.0 To: Marcel Holtmann CC: "linux-bluetooth@vger.kernel.org" Subject: Re: [PATCH] Quirk for Apple Aluminum Bluetooth keyboard FN key References: <48F50EEB.1060802@dell.com> <1224737771.9386.180.camel@californication> In-Reply-To: <1224737771.9386.180.camel@californication> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig182B6F5CBAFA1528037465EF" List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig182B6F5CBAFA1528037465EF Content-Type: multipart/alternative; boundary="------------080406010701050503010106" This is a multi-part message in MIME format. --------------080406010701050503010106 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Marcel: Marcel Holtmann wrote: > Hi Mario, > yeah, the Ubuntu kernel team is pretty bad in getting patches back to > upstream. However in this case please check with the upstream kernel > since the HID bus makes all quirks general to the HID subsystem. > > Regards > > Marcel Yeah, that's what I was thinking should be happening, and a little bit shocked that it didn't work properly since I saw a variation of this quirk in the hid source files already. I was a little thrown off though since there is already a quirk for the mighty mouse sitting in this section that I was patching, so it seemed sensible to add the quirk for the keyboard there too. I'll try to investigate why those quirks aren't carrying over properly. Regards --=20 Mario Limonciello *Dell | Linux Engineering* mario_limonciello@dell.com --------------080406010701050503010106 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Marcel:<= br>
Marcel Holtmann wrote: 
Hi Mario,
yeah, the Ubuntu kernel team is pretty bad in getting patches back to
upstream. However in this case please check with the upstream kernel
since the HID bus makes all quirks general to the HID subsystem.

Regards

Marcel
Yeah, that's what I was thinking should be happening, and a little bit shocked that it didn't work properly since I saw a variation of this quirk in the hid source files already.  I was a little thrown off though since there = is already a quirk for the mighty mouse sitting in this section that I was patching, so it seemed sensible to add the quirk for the keyboard there too.  I'll try to investigate why those quirks aren't carrying over properly.

Regards
--
Mario Limonciello
Dell | Linux Engineering
mario_limonciello@dell.com
--------------080406010701050503010106-- --------------enig182B6F5CBAFA1528037465EF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkkAp0wACgkQ2CrZjkA73YuIBACeKh5ElrsQn8F747OgUBFnsrgR fMMAoJB7C8Sy8QqBeoSoV4RH8ef2Ct/M =feiI -----END PGP SIGNATURE----- --------------enig182B6F5CBAFA1528037465EF-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] Quirk for Apple Aluminum Bluetooth keyboard FN key From: Marcel Holtmann To: Mario Limonciello Cc: "linux-bluetooth@vger.kernel.org" In-Reply-To: <48F50EEB.1060802@dell.com> References: <48F50EEB.1060802@dell.com> Content-Type: text/plain Date: Thu, 23 Oct 2008 06:56:11 +0200 Message-Id: <1224737771.9386.180.camel@californication> Mime-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Mario, > This patch was present in Ubuntu Hardy, but got dropped by accident in > Intrepid and never submitted upstream. It adds a quirk enabling the FN > key on the Apple Aluminum Bluetooth Wireless Keyboard. yeah, the Ubuntu kernel team is pretty bad in getting patches back to upstream. However in this case please check with the upstream kernel since the HID bus makes all quirks general to the HID subsystem. Regards Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <48F50EEB.1060802@dell.com> Date: Tue, 14 Oct 2008 16:28:11 -0500 From: Mario Limonciello MIME-Version: 1.0 To: "linux-bluetooth@vger.kernel.org" Subject: [PATCH] Quirk for Apple Aluminum Bluetooth keyboard FN key Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF6FC2DE8482CF3496A135EA4" Sender: linux-bluetooth-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF6FC2DE8482CF3496A135EA4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable This patch was present in Ubuntu Hardy, but got dropped by accident in Intrepid and never submitted upstream. It adds a quirk enabling the FN key on the Apple Aluminum Bluetooth Wireless Keyboard. Signed-off-by: Mario Limonciello --- net/bluetooth/hidp/core.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index 96434d7..fc6e643 100644 --- a/net/bluetooth/hidp/core.c +++ b/net/bluetooth/hidp/core.c @@ -684,6 +684,8 @@ static const struct { } hidp_blacklist[] =3D { /* Apple wireless Mighty Mouse */ { 0x05ac, 0x030c, HID_QUIRK_MIGHTYMOUSE | HID_QUIRK_INVERT_HWHEEL },= + /* Apple wireless Bluetooth Keyboard */ + { 0x05ac, 0x022c, HID_QUIRK_APPLE_HAS_FN }, =20 { } /* Terminating entry */ }; --=20 1.5.4.3 --------------enigF6FC2DE8482CF3496A135EA4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkj1DusACgkQ2CrZjkA73YuWrgCeJ5njcW0XgFCRBpG10h/sq+Pf HQkAnRYcwcYDkhjpIFZU/pBLECrBUbKD =jD3b -----END PGP SIGNATURE----- --------------enigF6FC2DE8482CF3496A135EA4--