public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Hoene <hoene@uni-tuebingen.de>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Cc: Frans de Bont <frans.de.bont@philips.com>
Subject: Re: [Bluez-devel] FW: REALLY Bad encoding performance of Linux SBC	audio codec
Date: Thu, 30 Oct 2008 17:07:24 +0100	[thread overview]
Message-ID: <1225382844.4626.13.camel@hoene-desktop> (raw)
In-Reply-To: <2d5a2c100810300846j79b94bf8h4d8974ed50b1ac23@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

On Thu, 2008-10-30 at 12:46 -0300, Luiz Augusto von Dentz wrote:
> Could you please send it as a real patch, I mean in diff format, or
> even better if you could configure a git repository so we could pull
> from.
> 
> Thank you for the contribution.

patch is attached.

[-- Attachment #2: sbcdec_buffer.patch --]
[-- Type: text/x-patch, Size: 895 bytes --]

diff --git a/sbc/sbcdec.c b/sbc/sbcdec.c
index 555ace5..2464c42 100644
--- a/sbc/sbcdec.c
+++ b/sbc/sbcdec.c
@@ -157,7 +157,7 @@ static void decode(char *filename, char *output, int tofile)
 		}
 	}
 
-	count = 0;
+	count = len;
 	while (framelen > 0) {
 		/* we have completed an sbc_decode at this point sbc.len is the
 		 * length of the frame we just decoded count is the number of
@@ -179,15 +179,15 @@ static void decode(char *filename, char *output, int tofile)
 			exit(1);
 		}
 
-		/* increase the count */
-		count += len;
-
 		/* push the pointer in the file forward to the next bit to be
 		 * decoded tell the decoder to decode up to the remaining
 		 * length of the file (!) */
 		pos += framelen;
 		framelen = sbc_decode(&sbc, stream + pos, streamlen - pos,
 					buf + count, sizeof(buf) - count, &len);
+
+		/* increase the count */
+		count += len;
 	}
 
 	if (count > 0) {

[-- Attachment #3: Type: text/plain, Size: 363 bytes --]

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2008-10-30 16:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 14:54 [Bluez-devel] FW: REALLY Bad encoding performance of Linux SBC audio codec Christian Hoene
2008-10-30 15:20 ` Christian Hoene
2008-10-30 15:46   ` Luiz Augusto von Dentz
2008-10-30 16:07     ` Christian Hoene [this message]
2008-10-30 18:02       ` Marcel Holtmann
2008-10-30 18:03   ` Marcel Holtmann
2008-10-30 18:48   ` Brad Midgley
2008-10-31 10:23     ` Christian Hoene
2008-10-31 11:10       ` Craig Southeren
2008-10-31 18:50       ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225382844.4626.13.camel@hoene-desktop \
    --to=hoene@uni-tuebingen.de \
    --cc=bluez-devel@lists.sourceforge.net \
    --cc=frans.de.bont@philips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox