[PATCH] Netlink patch.

[PATCH] Netlink patch.

[Alok]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

Hi Marcel, 

Attaching a patch which implements a generic netlink command
GET_DEVLIST(HCIGETDEVLIST). 
 
1. Will the netlink plugin expose an API like 
int hci_get_devlist(struct hci_dev_list_req *dl) ? 

2. If netlink registration fails would we fallback to raw sockets in the
plugin ?

Let me know if anything in the patch needs modification. 

Thanks, 
Alok.

[-- Attachment #2: 0001-Adding-netlink-support-to-bluetooth.patch --]
[-- Type: application/mbox, Size: 6005 bytes --]

Re: [PATCH] Netlink patch.

[Ville Tervo]

Hi Alok,

ext Alok wrote:
> Hi Marcel, 
> 
> Attaching a patch which implements a generic netlink command
> GET_DEVLIST(HCIGETDEVLIST). 

I don't know anything about netlink stuff but I'll give some generic comments :)


+	
+	if (info->attrs[NLBLUETOOTH_ATTR_DEVNUM]) {
+		dev_num = nla_get_u16(info->attrs[NLBLUETOOTH_ATTR_DEVNUM]);
+		if (!dev_num)
+			return -EINVAL;
+	} else
+		return -EINVAL;
+

I would prefer this kind code paths. Easier to read.

	if (!info->attrs[NLBLUETOOTH_ATTR_DEVNUM])
		return -EINVAL;

	dev_num = nla_get_u16(info->attrs[NLBLUETOOTH_ATTR_DEVNUM]);
	if (!dev_num)
		return -EINVAL;

+	msg = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
+
+	if (!msg)
+		return -ENOBUFS;
+
+	hdr = genlmsg_put(msg, 0, info->snd_seq+1, &nlbluetooth_fam, 0, NLBLUETOOTH_CMD_GET_DEVLIST);
+
+	if (hdr == NULL)
+		return -ENOMEM;

Is msg left unfreed here?

+
+	nl_list = nla_nest_start(msg, NLBLUETOOTH_ATTR_DEVLIST);
+	if (!nl_list)
+		goto nla_put_failure;

And here? I cannot find skb_free or friends from genlmsg_cancel() path.


-- 
Ville

[PATCH] Netlink patch.(modified)

[Alok]

[-- Attachment #1: Type: text/plain, Size: 120 bytes --]

Hi Marcel,

Attaching a modified netlink patch.
Forgot to free the buffer :) Thanks to ville for spotting it. 

-Alok. 

[-- Attachment #2: 0001-Adding-netlink-support-to-bluetooth.patch --]
[-- Type: application/mbox, Size: 5978 bytes --]