public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@nokia.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: To enablue DID in coming bluez release
Date: Wed, 17 Dec 2008 03:38:12 +0100	[thread overview]
Message-ID: <1229481492.10889.1.camel@violet> (raw)
In-Reply-To: <20081216102928.GA12914@localhost>

Hi Johan,

> Couple of comments:
> 
> On Tue, Dec 16, 2008, Li, Zhigang wrote:
> >  		main_opts.inqmode = val;
> >  	}
> > +	str = g_key_file_get_string(config, "General",
> 
> Coding style: add empty line after the closing bracket.
> 
> > +					"VID/PID/VER", &err);
> 
> Did you agree with this "VID/PID/VER" name with Marcel? I'd have used
> something like "DeviceID", "DeviceIDInfo" or "DIDInfo".

I think "DeviceID" sounds reasonable. Lets use that one.

Regards

Marcel



  parent reply	other threads:[~2008-12-17  2:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-12  1:52 To enablue DID in coming bluez release Li, Zhigang
2008-12-12  1:55 ` Marcel Holtmann
2008-12-16  7:55   ` Li, Zhigang
2008-12-16  9:59     ` Li, Zhigang
2008-12-16 10:29       ` Johan Hedberg
2008-12-17  2:17         ` Li, Zhigang
2008-12-17  2:25           ` David Sainty
2008-12-17  2:38         ` Marcel Holtmann [this message]
2008-12-17  3:10           ` Li, Zhigang
2008-12-17 19:59             ` Marcel Holtmann
2008-12-18  5:55               ` Li, Zhigang
2008-12-19 19:01                 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229481492.10889.1.camel@violet \
    --to=marcel@holtmann.org \
    --cc=johan.hedberg@nokia.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox