From: Christian Hoene <hoene@uni-tuebingen.de>
To: linux-bluetooth@vger.kernel.org
Subject: Patch for supporting even more command line parameters in sbcenc
Date: Tue, 23 Dec 2008 11:18:11 +0100 [thread overview]
Message-ID: <1230027491.20536.2.camel@hoene-desktop> (raw)
[-- Attachment #1: Type: text/plain, Size: 149 bytes --]
Hello,
in order to test the performance of SBC, I needed to add some more
parameter options to "sbcenc".
Attached the patch.
Greetings
Christian
[-- Attachment #2: adding.even.more.parameters.to.sbcenc.diff --]
[-- Type: text/x-patch, Size: 3612 bytes --]
diff --git a/sbc/sbcenc.c b/sbc/sbcenc.c
index 74a3434..e786c70 100644
--- a/sbc/sbcenc.c
+++ b/sbc/sbcenc.c
@@ -73,7 +73,7 @@ static ssize_t __write(int fd, const void *buf, size_t count)
}
static void encode(char *filename, int subbands,
- int bitpool, int joint, int snr)
+ int bitpool, int joint, int dualchannel, int snr, int blocks)
{
struct au_header *au_hdr;
unsigned char input[2048], output[2048];
@@ -131,4 +131,4 @@ static void encode(char *filename, int subbands,
sbc.subbands = subbands == 4 ? SBC_SB_4 : SBC_SB_8;
- if (BE_INT(au_hdr->channels) == 1)
+ if (BE_INT(au_hdr->channels) == 1) {
sbc.mode = SBC_MODE_MONO;
- else if (joint)
+ if(joint || dualchannel) {
+ fprintf(stderr, "Audio file is mono but joint or dualchannel mode has been specified\n");
+ goto done;
+ }
+ }
+ else if (joint && !dualchannel)
sbc.mode = SBC_MODE_JOINT_STEREO;
- else
- sbc.mode = SBC_MODE_STEREO;
-
+ else if(!joint && dualchannel)
+ sbc.mode = SBC_MODE_DUAL_CHANNEL;
+ else if(!joint && !dualchannel)
+ sbc.mode = SBC_MODE_STEREO;
+ else {
+ fprintf(stderr, "Both joint and dualchannel mode have been specified\n");
+ goto done;
+ }
+
sbc.endian = SBC_BE;
count = BE_INT(au_hdr->data_size);
size = len - BE_INT(au_hdr->hdr_size);
@@ -145,15 +156,17 @@ static void encode(char *filename, int subbands,
sbc.bitpool = bitpool;
sbc.allocation = snr ? SBC_AM_SNR : SBC_AM_LOUDNESS;
+ sbc.blocks = blocks / 4;
if(verbose) {
fprintf(stderr,"encoding %s with rate %d, %d subbands, "
- "%d bits, allocation method %s and mode %s\n",
+ "%d bits, allocation method %s, mode %s, and %d blocks\n",
filename, srate, subbands, bitpool,
sbc.allocation == SBC_AM_SNR ? "SNR" : "LOUDNESS",
sbc.mode == SBC_MODE_MONO ? "MONO" :
sbc.mode == SBC_MODE_STEREO ?
- "STEREO" : "JOINTSTEREO");
+ "STEREO" : "JOINTSTEREO",
+ blocks);
}
while (1) {
@@ -209,7 +222,9 @@ static void usage(void)
"\t-s, --subbands Number of subbands to use (4 or 8)\n"
"\t-b, --bitpool Bitpool value (default is 32)\n"
"\t-j, --joint Joint stereo\n"
+ "\t-d, --dualchannel Dual channel\n"
"\t-S, --snr Use SNR mode (default is loudness)\n"
+ "\t-B, --blocks Number of blocks to use (4, 8, 12 or 16)\n"
"\n");
}
@@ -219,15 +234,17 @@ static struct option main_options[] = {
{ "subbands", 1, 0, 's' },
{ "bitpool", 1, 0, 'b' },
{ "joint", 0, 0, 'j' },
+ { "dualchannel",0, 0, 'd' },
{ "snr", 0, 0, 'S' },
+ { "blocks", 1, 0, 'B' },
{ 0, 0, 0, 0 }
};
int main(int argc, char *argv[])
{
- int i, opt, subbands = 8, bitpool = 32, joint = 0, snr= 0;
+ int i, opt, subbands = 8, bitpool = 32, joint = 0, dualchannel = 0, snr = 0, blocks = 16;
- while ((opt = getopt_long(argc, argv, "+hvs:b:jS",
+ while ((opt = getopt_long(argc, argv, "+hvs:b:jdSB:",
main_options, NULL)) != -1) {
switch(opt) {
case 'h':
@@ -255,10 +272,23 @@ int main(int argc, char *argv[])
joint = 1;
break;
+ case 'd':
+ dualchannel = 1;
+ break;
+
case 'S':
snr = 1;
break;
+ case 'B':
+ blocks = atoi(optarg);
+ if (blocks != 16 && blocks != 12 && blocks != 8 && blocks != 4) {
+ fprintf(stderr, "Invalid blocks %d!\n",
+ blocks);
+ exit(1);
+ }
+ break;
+
default:
exit(1);
}
@@ -274,7 +304,7 @@ int main(int argc, char *argv[])
}
for (i = 0; i < argc; i++)
- encode(argv[i], subbands, bitpool, joint, snr);
+ encode(argv[i], subbands, bitpool, joint, dualchannel, snr, blocks);
return 0;
}
next reply other threads:[~2008-12-23 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-23 10:18 Christian Hoene [this message]
2008-12-23 10:42 ` Patch for supporting even more command line parameters in sbcenc Marcel Holtmann
2008-12-23 12:56 ` Christian Hoene
2008-12-23 14:28 ` Patch for supporting even more command line parameters in sbcenc UPDATE Christian Hoene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230027491.20536.2.camel@hoene-desktop \
--to=hoene@uni-tuebingen.de \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox