From: Marcel Holtmann <marcel@holtmann.org>
To: Jesse Long <jpl@unknown.za.net>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: rfcomm exit code patch
Date: Tue, 06 Jan 2009 03:38:29 +0100 [thread overview]
Message-ID: <1231209509.13304.10.camel@californication> (raw)
In-Reply-To: <49626427.1020501@unknown.za.net>
Hi Jesse,
> rfcomm does not always indicate failure in it's exit codes, which is a
> problem when automating things.
>
> Please consider this patch.
your patch is full of whitespaces/tabs coding style violations. Please
fix them first.
Also error return values should be negative.
Regards
Marcel
next prev parent reply other threads:[~2009-01-06 2:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 19:48 rfcomm exit code patch Jesse Long
2009-01-06 2:38 ` Marcel Holtmann [this message]
2009-01-06 14:52 ` Jesse Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231209509.13304.10.camel@californication \
--to=marcel@holtmann.org \
--cc=jpl@unknown.za.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox