From: Marcel Holtmann <marcel@holtmann.org>
To: David Sainty <david.sainty@dtsp.co.nz>
Cc: Khem Raj <raj.khem@gmail.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [patch] hid2hci check usb_init return value
Date: Tue, 06 Jan 2009 06:19:14 +0100 [thread overview]
Message-ID: <1231219154.13304.23.camel@californication> (raw)
In-Reply-To: <4962C9D0.1030005@dtsp.co.nz>
Hi David,
> >> What you have is libusb-0.1 which has older API I suppose. There is
> >> libusb-compat which can be used as a wrapper over libusb1 to give
> >> libusb0 like interfaces.
> >>
> >> Actually I was using libusb-1.0.0 API as mentioned here
> >> http://libusb.sourceforge.net/api-1.0/group__lib.html
> >> that also means that the patch I attached should have been using
> >> libusb_init() instead.
> >>
> >> Here is updated patch
> >>
> >
> > this still breaks with a system that has libusb-0.1 installed like the
> > current Ubuntu 8.10 does. So either we switch to libusb-1.0 completely
> > or we leave it as it is.
> >
>
> This looks like a job for autoconf?
it could be, but I am only doing either libusb-0.1 or libusb-1.0. We can
have support for both, but these compile time options are a bad thing
and I don't want them.
Regards
Marcel
next prev parent reply other threads:[~2009-01-06 5:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-25 23:14 [patch] hid2hci check usb_init return value Khem Raj
2008-12-29 12:12 ` Marcel Holtmann
2008-12-30 6:26 ` Khem Raj
2009-01-06 2:54 ` Marcel Holtmann
2009-01-06 3:02 ` David Sainty
2009-01-06 5:19 ` Marcel Holtmann [this message]
2009-01-06 18:17 ` Khem Raj
2009-01-06 18:21 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231219154.13304.23.camel@californication \
--to=marcel@holtmann.org \
--cc=david.sainty@dtsp.co.nz \
--cc=linux-bluetooth@vger.kernel.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox