From: Marcel Holtmann <marcel@holtmann.org>
To: Siarhei Siamashka <siarhei.siamashka@nokia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Performance optimizations for sbcenc utility
Date: Mon, 19 Jan 2009 13:04:21 +0100 [thread overview]
Message-ID: <1232366661.19390.14.camel@californication> (raw)
In-Reply-To: <200901191305.36942.siarhei.siamashka@nokia.com>
Hi Siarhei,
> > > The attached patch improves performance of sbcenc utility. This is not
> > > very useful in general and does not improve the SBC codec itself. But
> > > when using sbcenc utility for benchmarking, an extra unneeded overhead
> > > skews the results a bit and this might be worth fixing.
> > >
> > > Before patch:
> > >
> > > real 0m14.984s
> > > user 0m12.981s
> > > sys 0m1.924s
> > >
> > > After patch:
> > >
> > > real 0m12.279s
> > > user 0m11.865s
> > > sys 0m0.360s
> > >
> > >
> > > Christian, you fixed some bugs in sbcenc a bit earlier. Could you please
> > > also check if all your testcases also work fine with this new patch
> > > applied and it does not break anything?
> >
> > patch has been applied to make testing easier. Send fixes if it breaks
> > something.
>
> Well, appears that it really broke something. I forgot to update the part of
> code which handled non 24 byte headers. A fix is attached. Now it should
> work fine in all cases.
patch has been applied. Thanks.
Regards
Marcel
prev parent reply other threads:[~2009-01-19 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 16:12 [PATCH] Performance optimizations for sbcenc utility Siarhei Siamashka
2009-01-18 15:15 ` Marcel Holtmann
2009-01-19 11:05 ` Siarhei Siamashka
2009-01-19 12:04 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232366661.19390.14.camel@californication \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=siarhei.siamashka@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox