From: Marcel Holtmann <marcel@holtmann.org>
To: Zhao Forrest <forrest.zhao@gmail.com>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 2/4] add the basic framework support for HFP Audio gateway -- take 2 -- resend
Date: Fri, 20 Feb 2009 21:19:51 +0100 [thread overview]
Message-ID: <1235161191.24255.23.camel@californication> (raw)
In-Reply-To: <ac8af0be0902200542r354d57fbp8a285162c7675d00@mail.gmail.com>
Hi Forrest,
> +struct gateway {
> + GIOChannel* rfcomm;
> + guint rfcomm_watch_id;
> + GIOChannel* sco;
> + GIOChannel* sco_server;
> + gateway_stream_cb_t sco_start_cb;
> + void* sco_start_cb_data;
> + DBusMessage* connect_message;
> + guint ag_features;
> + guint hold_multiparty_features;
> + GSList* indies;
> + gboolean is_dialing;
> +};
it is GIOChannel<space>*rfcomm. And that applies to all other
occurrences, too. Sorry, but coding style fixes first before we do
actual review of the code.
Regards
Marcel
prev parent reply other threads:[~2009-02-20 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 13:42 [PATCH 2/4] add the basic framework support for HFP Audio gateway -- take 2 -- resend Zhao Forrest
2009-02-20 20:19 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235161191.24255.23.camel@californication \
--to=marcel@holtmann.org \
--cc=forrest.zhao@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox