public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Brian Rogers <brian@xyzw.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: btusb compatibility issues
Date: Wed, 25 Feb 2009 11:00:24 +0100	[thread overview]
Message-ID: <1235556025.24169.17.camel@localhost.localdomain> (raw)
In-Reply-To: <49A2A2D4.2020904@xyzw.org>

Hi Brian,

> >>> Also please run a kernel built from bluetooth-testing.git so I can
> >>> properly debug this. There is one change in it that affects the bulk
> >>> URBs and maybe these dongles just don't like it if we only submit them
> >>> when needed.
> >> I found bluetooth-testing.git last night after posting here, and merged 
> >> it into my kernel. Today I just tested it, and the problem is solved 
> >> here. So there's probably no reason to provide the dump anymore. Will 
> >> this fix be backported to 2.6.27 and 2.6.28?
> >>     
> >
> > not likely since it is not clear what is causing it. There can be some
> > other changes in the tree that could have broken and fixed it. Sometimes
> > this is not Bluetooth related.
> >   
> 
> Maybe this isn't the same as knowing what's causing it, but I'm pretty 
> sure that 'Submit bulk URBs along with interrupt URBs' fixed it. I had 
> done some bisecting in search of the problem and never found a point 
> before it where btusb worked with the affected dongle. Rolling back to 
> just before that commit reproduces the problem, and then stepping 
> forward one fixes it again. I also tried starting with 2.6.27 and 
> cherry-picking the changes that touch drivers/bluetooth/btusb.c. That 
> also produced working Bluetooth as soon as that same commit was added.
> 
> Anyway, if it does not get backported to the official stable branches, I 
> think some distros will still want to add it to their kernels. I'll try 
> to get this into Ubuntu Jaunty's 2.6.28 kernel. So for the sake of me 
> saying "this is the fix applied upstream", do you have an ETA on when 
> this stuff will be merged into the kernel mainline?

I will be sending them for net-next inclusion during this week. Just
have to apply one additional patch and verify that it is fixing a crash
we saw lately.

Regards

Marcel



  reply	other threads:[~2009-02-25 10:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-08 10:14 btusb compatibility issues Brian Rogers
2009-02-08 17:10 ` Marcel Holtmann
2009-02-09  0:43   ` Brian Rogers
2009-02-09 12:39     ` Marcel Holtmann
2009-02-23 13:21       ` Brian Rogers
2009-02-25 10:00         ` Marcel Holtmann [this message]
2009-02-26 13:09           ` Issues in PANU Chan-Yeol Park
2009-02-26 16:03             ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1235556025.24169.17.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=brian@xyzw.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox