Re: [PATCH] Bluetooth: i reaches pkts_to_be_removed + 1

Marcel Holtmann
2009-02-25T22:40:39Z

Hi Roel,

> i reaches pkts_to_be_removed + 1
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c
> index 894b2cb..177f34b 100644
> --- a/drivers/bluetooth/hci_bcsp.c
> +++ b/drivers/bluetooth/hci_bcsp.c
> @@ -385,7 +385,7 @@ static void bcsp_pkt_cull(struct bcsp_struct *bcsp)
>
> spin_unlock_irqrestore(&bcsp->unack.lock, flags);
>
> - if (i != pkts_to_be_removed)
> + if (i <= pkts_to_be_removed)
> BT_ERR("Removed only %u out of %u pkts", i, pkts_to_be_removed);
> }

patch looks good, but can you please fill in the commit message with a
little bit more details and background.

Regards

Marcel