Re: [PATCH] Bluetooth: i reaches pkts_to_be_removed + 1

Roel Kluin
2009-03-02T12:37:22Z

>> Isn't there something wrong with this? The patched code looks like it
>> will output apparently nonsensical messages like "Removed only 10 out of
>> 10 pkts".
>
> yeah, that would make no real sense. I actually just thought about why
> we have that error message at all. We should remove the message all together.
------------------------------>8-------------8<---------------------------------
When all packets are removed 'i' reaches pkts_to_be_removed + 1, so the error
message was printed upon success, and not when the last packet wasn't removed.
Since it results in nonsensical messages, it was decided to remove the test
altogether.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c
index 894b2cb..52c6bdc 100644
--- a/drivers/bluetooth/hci_bcsp.c
+++ b/drivers/bluetooth/hci_bcsp.c
@@ -384,9 +384,6 @@ static void bcsp_pkt_cull(struct bcsp_struct *bcsp)
del_timer(&bcsp->tbcsp);

spin_unlock_irqrestore(&bcsp->unack.lock, flags);
-
- if (i != pkts_to_be_removed)
- BT_ERR("Removed only %u out of %u pkts", i, pkts_to_be_removed);
}

/* Handle BCSP link-establishment packets. When we