Re: [PATCH] Fix segfault: If the interface name is NULL the bluetoothd daemon will crash

Frieder Buerzele
2009-02-26T08:46:46Z

> > Hi Frieder,
> >
> > > ---
> > > gdbus/object.c | 11 ++++++-----
> > > 1 files changed, 6 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/gdbus/object.c b/gdbus/object.c
> > > index 0786aeb..d920eac 100644
> > > --- a/gdbus/object.c
> > > +++ b/gdbus/object.c
> > > @@ -224,11 +224,12 @@ static struct interface_data
> > > *find_interface(GSList *interfaces,
> > > {
> > > GSList *list;
> > >
> > > - for (list = interfaces; list; list = list->next) {
> > > - struct interface_data *iface = list->data;
> > > - if (!strcmp(name, iface->name))
> > > - return iface;
> > > - }
> > > + if (name)
> > > + for (list = interfaces; list; list = list->next) {
> > > + struct interface_data *iface = list->data;
> > > + if (!strcmp(name, iface->name))
> > > + return iface;
> > > + }
> > >
> > > return NULL;
> > > }
> >
> > what about something like this:
> >
> > if (name == NULL)
> > return NULL;
> >
> > Regards
> >
> > Marcel
> >
>
> k, I'll resend a updated patch
>
> Greetz Frieder

just forget to test compile the patch, here is the "fixed" fix patch

Greetz Frieder