public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: linux-bluetooth@vger.kernel.org,
	linux-pcmcia@lists.infradead.org,
	Dominik Brodowski <linux@dominikbrodowski.net>
Subject: Re: [PATCH] pcmcia: dtl1_cs: fix pcmcia_loop_config logic
Date: Sat, 28 Feb 2009 22:35:37 +0100	[thread overview]
Message-ID: <1235856937.6074.35.camel@localhost.localdomain> (raw)
In-Reply-To: <1235753648-10045-1-git-send-email-philipp.zabel@gmail.com>

Hi Philipp,

> pcmcia_loop_config returns 0 on success.
> 
> Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
> ---
>  drivers/bluetooth/dtl1_cs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/bluetooth/dtl1_cs.c b/drivers/bluetooth/dtl1_cs.c
> index 901bdd9..e0ee642 100644
> --- a/drivers/bluetooth/dtl1_cs.c
> +++ b/drivers/bluetooth/dtl1_cs.c
> @@ -616,7 +616,7 @@ static int dtl1_config(struct pcmcia_device *link)
>  
>  	/* Look for a generic full-sized window */
>  	link->io.NumPorts1 = 8;
> -	if (!pcmcia_loop_config(link, dtl1_confcheck, NULL))
> +	if (pcmcia_loop_config(link, dtl1_confcheck, NULL))
>  		goto failed;
>  
>  	i = pcmcia_request_irq(link, &link->irq);

can you check the other Bluetooth PCMCIA drivers, too. One of the PCMCIA
subsystem changes might have screwed this up and affects more drivers
than expected.

Regards

Marcel



  parent reply	other threads:[~2009-02-28 21:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-27 16:54 [PATCH] pcmcia: dtl1_cs: fix pcmcia_loop_config logic Philipp Zabel
2009-02-27 22:35 ` pHilipp Zabel
2009-02-28 21:38   ` Marcel Holtmann
2009-07-27  9:58   ` Wolfram Sang
2009-07-27 10:13     ` Marcel Holtmann
2009-07-27 10:30       ` Wolfram Sang
2009-02-28 21:35 ` Marcel Holtmann [this message]
2009-02-28 22:16   ` pHilipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1235856937.6074.35.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=linux@dominikbrodowski.net \
    --cc=philipp.zabel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox