From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cyrus@holtmann.org>
Subject: Re: Broken SDP parsing?
From: Bastien Nocera <hadess@hadess.net>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	linux-bluetooth@vger.kernel.org
In-Reply-To: <20090313181533.GA12975@jh-x301>
References: <1236301226.3602.2314.camel@cookie.hadess.net>
	 <1236523586.16880.141.camel@cookie.hadess.net>
	 <2d5a2c100903090608kd4ffea6sd9b1746e2362bf2@mail.gmail.com>
	 <1236608040.16880.1580.camel@cookie.hadess.net>
	 <2d5a2c100903090732x6d677dccp747c469b43906f71@mail.gmail.com>
	 <1236612318.16880.1656.camel@cookie.hadess.net>
	 <2d5a2c100903090940m4aa3b7bbj5c0528ea1b175d5e@mail.gmail.com>
	 <1236618579.32264.23.camel@cookie.hadess.net>
	 <20090309174644.GA4340@jh-x301>
	 <1236958673.32264.5799.camel@cookie.hadess.net>
	 <20090313181533.GA12975@jh-x301>
Content-Type: text/plain; charset="UTF-8"
Date: Sat, 14 Mar 2009 00:39:28 +0000
Message-Id: <1236991168.32264.6353.camel@cookie.hadess.net>
Mime-Version: 1.0
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

On Fri, 2009-03-13 at 15:15 -0300, Johan Hedberg wrote:
> Hi Bastien,
> 
> On Fri, Mar 13, 2009, Bastien Nocera wrote:
> > FWIW, I just copied the coding style from the function 5 lines above it.
> 
> Yeah, the SDP code is full of broken coding style that we just haven't
> had the time to fix.
> 
> > Patches attached.
> 
> Thanks. I had to fix the following warning in the cups patch, but
> otherwise they were fine:
> main.c: In function ‘device_get_ieee1284_id’:
> main.c:129: error: ‘id’ may be used uninitialized in this function

I didn't see this. Must be my gcc being low on warnings.

I did notice a "return FALSE" in device_get_ieee1284_id(), when it
should be a "return NULL" though. Could you get that pushed?

> The patches have now been pushed upstream.

Great, thanks.