From: Marcel Holtmann <marcel@holtmann.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Wacom Bluetooth mode-2 activation
Date: Sat, 14 Mar 2009 07:09:48 +0100 [thread overview]
Message-ID: <1237010988.24751.2.camel@localhost.localdomain> (raw)
In-Reply-To: <1237334085.15346.99.camel@cookie.hadess.net>
Hi Bastien,
> Patch is necessary to make the Wacom Bluetooth driver I posted to
> linux-input work as expected. I've tested this successfully with my
> tablet[1].
this maybe sound like a nit-pick, but please add an extra empty line
between the if-statement and the ioctl.
+ write(sk, buf, sizeof(buf));
+ }
err = ioctl_connadd(req);
The original code had one and so should have the new one with this extra
quirk.
Also can we please check at least the return value of write().
+ write(sk, buf, sizeof(buf));
Check the return value and at minimum have an error message printed.
Regards
Marcel
next prev parent reply other threads:[~2009-03-14 6:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 23:54 [PATCH] Wacom Bluetooth mode-2 activation Bastien Nocera
2009-03-14 6:09 ` Marcel Holtmann [this message]
2009-03-23 14:09 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237010988.24751.2.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox