From: Marcel Holtmann <marcel@holtmann.org>
To: Nick Pelly <npelly@google.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] AVDTP Qualification: Fix error handling for AVDTP set configuration command
Date: Thu, 26 Mar 2009 00:01:36 +0100 [thread overview]
Message-ID: <1238022096.8206.1.camel@localhost.localdomain> (raw)
In-Reply-To: <35c90d960903261651i46cb32c6qc061f7f718e3d669@mail.gmail.com>
Hi Nick,
> +
> + if ((cap->category == AVDTP_MEDIA_TRANSPORT) &&
> (cap->length != 0)) {
> + err = AVDTP_BAD_MEDIA_TRANSPORT_FORMAT;
> + goto failed;
no need to put brackets around cap->cat == ... check etc. The comparison
takes precedence over &&. Please fix and re-send the patch.
Regards
Marcel
next prev parent reply other threads:[~2009-03-25 23:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 23:51 [PATCH] AVDTP Qualification: Fix error handling for AVDTP set configuration command Nick Pelly
2009-03-25 23:01 ` Marcel Holtmann [this message]
2009-03-27 0:43 ` Nick Pelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238022096.8206.1.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=npelly@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox