From: "Gustavo F. Padovan" <gustavo@las.ic.unicamp.br>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 2/3] Fix null dereference in gdbus/watch.c
Date: Tue, 31 Mar 2009 23:30:44 -0300 [thread overview]
Message-ID: <1238553045-23938-2-git-send-email-gustavo@las.ic.unicamp.br> (raw)
In-Reply-To: <1238553045-23938-1-git-send-email-gustavo@las.ic.unicamp.br>
If name or data->name is null we have a null dereference. Not name and
data->name.
---
gdbus/watch.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gdbus/watch.c b/gdbus/watch.c
index 38bf3d7..607803c 100644
--- a/gdbus/watch.c
+++ b/gdbus/watch.c
@@ -62,7 +62,7 @@ static struct name_data *name_data_find(DBusConnection *connection,
current != NULL; current = current->next) {
struct name_data *data = current->data;
- if (name == NULL && data->name == NULL) {
+ if (name == NULL || data->name == NULL) {
if (connection == data->connection)
return data;
} else {
--
1.6.0.6
next prev parent reply other threads:[~2009-04-01 2:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 2:30 [PATCH 1/3] Fix null dereference in src/main.c Gustavo F. Padovan
2009-04-01 2:30 ` Gustavo F. Padovan [this message]
2009-04-01 2:30 ` [PATCH 3/3] Fix memset of sco_opt Gustavo F. Padovan
2009-04-01 5:56 ` Johan Hedberg
2009-04-01 5:54 ` [PATCH 2/3] Fix null dereference in gdbus/watch.c Johan Hedberg
2009-04-01 5:52 ` [PATCH 1/3] Fix null dereference in src/main.c Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238553045-23938-2-git-send-email-gustavo@las.ic.unicamp.br \
--to=gustavo@las.ic.unicamp.br \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox