public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Scott Talbot <psyc@stalbot.com>
To: linux-bluetooth@vger.kernel.org
Cc: Scott Talbot <psyc@stalbot.com>
Subject: [PATCH] Fix sending AVRCP button released passthrough messages
Date: Thu, 23 Apr 2009 21:53:36 +1000	[thread overview]
Message-ID: <1240487616-8920-1-git-send-email-psyc@stalbot.com> (raw)

Set the high bit in the op value for the button released event rather
than clearing the entire field.
---
 audio/control.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/audio/control.c b/audio/control.c
index e0451e7..5cc4a31 100644
--- a/audio/control.c
+++ b/audio/control.c
@@ -937,7 +937,7 @@ static int avctp_send_passthrough(struct control *control, uint8_t op)
 
 	/* Button release */
 	avctp->transaction = transaction++;
-	operands[0] &= 0x80;
+	operands[0] |= 0x80;
 
 	return write(sk, buf, sizeof(buf));
 }
-- 
1.6.0.6


             reply	other threads:[~2009-04-23 11:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23 11:53 Scott Talbot [this message]
2009-04-23 12:42 ` [PATCH] Fix sending AVRCP button released passthrough messages Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240487616-8920-1-git-send-email-psyc@stalbot.com \
    --to=psyc@stalbot.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox