From: Forrest Zhao <forrest.zhao@intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: forrest.zhao@gmail.com, Forrest Zhao <forrest.zhao@intel.com>
Subject: [PATCH] in headset_init(), it's possible that hs->hfp_handle is not set, so we should not check hs->hfp_handle in headset_connect_cb()
Date: Wed, 6 May 2009 17:19:00 +0800 [thread overview]
Message-ID: <1241601540-6540-1-git-send-email-forrest.zhao@intel.com> (raw)
We found this bug when developing the HFP plugin for telephonyd.
---
audio/headset.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/audio/headset.c b/audio/headset.c
index 9f6b736..9b9be17 100644
--- a/audio/headset.c
+++ b/audio/headset.c
@@ -1304,8 +1304,7 @@ void headset_connect_cb(GIOChannel *chan, GError *err, gpointer user_data)
else
hs->auto_dc = FALSE;
- if (server_is_enabled(&dev->src, HANDSFREE_SVCLASS_ID) &&
- hs->hfp_handle != 0)
+ if (server_is_enabled(&dev->src, HANDSFREE_SVCLASS_ID))
hs->hfp_active = TRUE;
else
hs->hfp_active = FALSE;
--
1.5.4.5
next reply other threads:[~2009-05-06 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 9:19 Forrest Zhao [this message]
2009-05-06 9:30 ` [PATCH] in headset_init(), it's possible that hs->hfp_handle is not set, so we should not check hs->hfp_handle in headset_connect_cb() Johan Hedberg
2009-05-06 12:28 ` Zhao Forrest
2009-05-07 2:03 ` Zhao Forrest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241601540-6540-1-git-send-email-forrest.zhao@intel.com \
--to=forrest.zhao@intel.com \
--cc=forrest.zhao@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox