From: Marcel Holtmann <marcel@holtmann.org>
To: Bing Zhao <bzhao@marvell.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: bluetooth: module_refcount is not decreased when connection times out
Date: Fri, 08 May 2009 16:20:19 -0700 [thread overview]
Message-ID: <1241824819.4903.70.camel@localhost.localdomain> (raw)
In-Reply-To: <477F20668A386D41ADCC57781B1F704301E62956E5@SC-VEXCH1.marvell.com>
Hi Bing,
> The module refcount is increased by hci_dev_hold() call in hci_conn_add() in hci_conn.c, and it is decreased by hci_dev_put() call in "del_conn" (hci_sysfs.c).
>
> In case connection timeout happens, hci_dev_put() is never called.
>
> Procedure to reproduce the issue:
>
> # hciconfig hci0 up
> # lsmod | grep btusb -> "used by" refcount = 1
>
> # hcitool cc <non-exisiting bdaddr> -> will get timeout
>
> # lsmod | grep btusb -> "used by" refcount = 2
> # hciconfig hci0 down
> # lsmod | grep btusb -> "used by" refcount = 1
> # rmmod btusb -> ERROR: Module btusb is in use
I have seen that happen before, but never had the time to check up on
them. Your analysis seems correct. Would have to check on how to fix
this. Proposals are welcome.
Regards
Marcel
next prev parent reply other threads:[~2009-05-08 23:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 22:59 bluetooth: module_refcount is not decreased when connection times out Bing Zhao
2009-05-08 23:20 ` Marcel Holtmann [this message]
2009-05-08 23:27 ` Marcel Holtmann
2009-05-09 0:01 ` Bing Zhao
2009-05-09 0:03 ` Marcel Holtmann
2009-05-09 1:08 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241824819.4903.70.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=bzhao@marvell.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox