From: Marcel Holtmann <marcel@holtmann.org>
To: Yu Kang Ku <infinity@hagao.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: Question on hci_remote_features_evt()
Date: Thu, 14 May 2009 13:26:52 -0700 [thread overview]
Message-ID: <1242332812.27899.13.camel@localhost.localdomain> (raw)
In-Reply-To: <40827.38703.qm@web303.biz.mail.mud.yahoo.com>
Hi Kang,
> In http://lxr.linux.no/linux+v2.6.27/net/bluetooth/hci_event.c, hci_remote_features_evt() contains the following code:
>
> if (!ev->status && lmp_ssp_capable(hdev) &&
> lmp_ssp_capable(conn)) {
> struct hci_cp_read_remote_ext_features cp;
> cp.handle = ev->handle;
> cp.page = 0x01;
> hci_send_cmd(hdev,
> HCI_OP_READ_REMOTE_EXT_FEATURES,
> sizeof(cp), &cp);
> }
>
> Should the if-statement check to make sure LMP Extended Features is supported before sending the HCI_OP_READ_REMOTE_EXT_FEATURES command? Or does the fact that a remote device is SSP-capable imply LMP Extended Features is supported as well?
if you support SSP, you have to support extended features. The host
features bits for SSP are in the second features page and thus it is
required to support this.
Regards
Marcel
prev parent reply other threads:[~2009-05-14 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 20:17 Question on hci_remote_features_evt() Yu Kang Ku
2009-05-14 20:26 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242332812.27899.13.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=infinity@hagao.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox