From: alokbarsode@gmail.com
To: linux-bluetooth@vger.kernel.org
Cc: marcel@holtmann.org, Alok Barsode <alok.barsode@azingo.com>
Subject: [PATCH 4/7] Adding set_discoverable method to hciops.
Date: Mon, 18 May 2009 15:19:10 +0530 [thread overview]
Message-ID: <1242640153-23420-4-git-send-email-alok.barsode@azingo.com> (raw)
In-Reply-To: <1242640153-23420-3-git-send-email-alok.barsode@azingo.com>
From: Alok Barsode <alok.barsode@azingo.com>
---
plugins/hciops.c | 18 ++++++++++++++++++
src/adapter.c | 46 +++++++++++++++++++---------------------------
src/adapter.h | 1 +
3 files changed, 38 insertions(+), 27 deletions(-)
diff --git a/plugins/hciops.c b/plugins/hciops.c
index 15084e4..184ed9c 100644
--- a/plugins/hciops.c
+++ b/plugins/hciops.c
@@ -499,6 +499,23 @@ static int hciops_connectable(int index)
return 0;
}
+static int hciops_discoverable(int index)
+{
+ int dd;
+ uint8_t mode = (SCAN_PAGE | SCAN_INQUIRY);
+
+ dd = hci_open_dev(index);
+ if (dd < 0)
+ return -EIO;
+
+ hci_send_cmd(dd, OGF_HOST_CTL, OCF_WRITE_SCAN_ENABLE,
+ 1, &mode);
+
+ hci_close_dev(dd);
+
+ return 0;
+}
+
static struct btd_adapter_ops hci_ops = {
.setup = hciops_setup,
.cleanup = hciops_cleanup,
@@ -506,6 +523,7 @@ static struct btd_adapter_ops hci_ops = {
.stop = hciops_stop,
.set_powered = hciops_powered,
.set_connectable = hciops_connectable,
+ .set_discoverable = hciops_discoverable,
};
static int hciops_init(void)
diff --git a/src/adapter.c b/src/adapter.c
index 121694d..cd18412 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -409,24 +409,13 @@ static int set_mode(struct btd_adapter *adapter, uint8_t new_mode)
}
if (current_scan != scan_enable) {
- if (scan_enable == SCAN_PAGE) {
+ if (scan_enable == SCAN_PAGE)
err = adapter_ops->set_connectable(adapter->dev_id);
- if (err < 0)
- return err;
- } else {
- dd = hci_open_dev(adapter->dev_id);
- if (dd < 0)
- return -EIO;
-
- err = hci_send_cmd(dd, OGF_HOST_CTL, OCF_WRITE_SCAN_ENABLE,
- 1, &scan_enable);
- if (err < 0) {
- hci_close_dev(dd);
- return err;
- }
-
- hci_close_dev(dd);
- }
+ else
+ err = adapter_ops->set_discoverable(adapter->dev_id);
+
+ if (err < 0)
+ return err;
} else if ((scan_enable & SCAN_INQUIRY) &&
(new_mode != adapter->mode)) {
adapter_remove_discov_timeout(adapter);
@@ -2001,7 +1990,7 @@ static int adapter_up(struct btd_adapter *adapter)
char mode[14], srcaddr[18];
uint8_t scan_mode;
gboolean powered, dev_down = FALSE;
- int dd;
+ int dd, err;
ba2str(&adapter->bdaddr, srcaddr);
@@ -2054,19 +2043,22 @@ static int adapter_up(struct btd_adapter *adapter)
}
proceed:
- dd = hci_open_dev(adapter->dev_id);
-
- if (dd < 0)
- return -EIO;
+ if (scan_mode == SCAN_PAGE)
+ err = adapter_ops->set_connectable(adapter->dev_id);
+ else
+ err = adapter_ops->set_discoverable(adapter->dev_id);
- if (dev_down == FALSE)
- hci_send_cmd(dd, OGF_HOST_CTL, OCF_WRITE_SCAN_ENABLE,
- 1, &scan_mode);
+ if (err < 0)
+ return err;
if (adapter->initialized == FALSE) {
load_drivers(adapter);
load_devices(adapter);
+ dd = hci_open_dev(adapter->dev_id);
+ if (dd < 0)
+ return -EIO;
+
/* retrieve the active connections: address the scenario where
* the are active connections before the daemon've started */
load_connections(adapter, dd);
@@ -2074,6 +2066,8 @@ proceed:
adapter->initialized = TRUE;
manager_add_adapter(adapter->path);
+
+ hci_close_dev(dd);
}
if (adapter->svc_cache)
@@ -2088,8 +2082,6 @@ proceed:
ADAPTER_INTERFACE, "Powered",
DBUS_TYPE_BOOLEAN, &powered);
- hci_close_dev(dd);
-
return 0;
}
diff --git a/src/adapter.h b/src/adapter.h
index 0bfad8a..bfd2826 100644
--- a/src/adapter.h
+++ b/src/adapter.h
@@ -154,6 +154,7 @@ struct btd_adapter_ops {
int (*stop) (int index);
int (*set_powered) (int index, gboolean powered);
int (*set_connectable) (int index);
+ int (*set_discoverable) (int index);
};
int btd_register_adapter_ops(struct btd_adapter_ops *btd_adapter_ops);
--
1.5.6.3
next prev parent reply other threads:[~2009-05-18 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 9:49 [PATCH 1/7] Using hci_send_cmd instead of hci_send_req to set scan mode alokbarsode
2009-05-18 9:49 ` [PATCH 2/7] Adding set_powered method to hciops plugin alokbarsode
2009-05-18 9:49 ` [PATCH 3/7] Adding set_connectable " alokbarsode
2009-05-18 9:49 ` alokbarsode [this message]
2009-05-18 9:49 ` [PATCH 5/7] Modifying load_connections method alokbarsode
2009-05-18 9:49 ` [PATCH 6/7] Adding set_limited_discoverable method to hciops plugin alokbarsode
2009-05-18 9:49 ` [PATCH 7/7] Code cleanup in set_mode alokbarsode
-- strict thread matches above, loose matches on Subject: below --
2009-05-12 12:26 [PATCH 1/7] Using hci_send_cmd instead of hci_send_req to set scan mode alokbarsode
2009-05-12 12:26 ` [PATCH 2/7] Adding set_powered method to hciops plugin alokbarsode
2009-05-12 12:26 ` [PATCH 3/7] Adding set_connectable " alokbarsode
2009-05-12 12:26 ` [PATCH 4/7] Adding set_discoverable method to hciops alokbarsode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242640153-23420-4-git-send-email-alok.barsode@azingo.com \
--to=alokbarsode@gmail.com \
--cc=alok.barsode@azingo.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox