From: Marcel Holtmann <marcel@holtmann.org>
To: Mario Limonciello <mario_limonciello@dell.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Reinstitute usb_detach_kernel_driver_np, but in the proper place.
Date: Mon, 18 May 2009 11:20:50 -0700 [thread overview]
Message-ID: <1242670850.3446.45.camel@localhost.localdomain> (raw)
In-Reply-To: <4A11A51A.7030109@dell.com>
Hi Mario,
> Testing a little more, I found that on fresh boots the latest bluez.git
> doesn't always work to switch dell BT adapters to HCI mode depending on
> the state of the killswitch on boot. Whenever running hid2hci, the
> kernel driver should attempt to be released. As long as this is done
> before trying to claim, each of the scenarios is successful. The
> previous dmesg errors were coming up because the order of the
> usb_claim_interface and usb_detach_kernel_driver_np were reversed.
the patch has been applied. However I prefer if you stop making the code
so complex that my brain hurts. I changed that now. It should really
just to "if error then bail out of the function".
Regards
Marcel
prev parent reply other threads:[~2009-05-18 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 18:12 [PATCH] Reinstitute usb_detach_kernel_driver_np, but in the proper place Mario Limonciello
2009-05-18 18:20 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242670850.3446.45.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mario_limonciello@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox