From: Marcel Holtmann <marcel@holtmann.org>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/4] bluetooth: add bt_mrvl driver to support Marvell bluetooth devices
Date: Wed, 20 May 2009 17:45:54 -0700 [thread overview]
Message-ID: <1242866754.3147.81.camel@localhost.localdomain> (raw)
In-Reply-To: <1242866141-22325-1-git-send-email-bzhao@marvell.com>
Hi Bing,
> This driver, bt_mrvl, provides basic definitions and library functions
> to support Marvell Bluetooth enabled devices, such as 88W8688 WLAN/BT
> combo chip.
>
> This patch incorporates a lot of comments given by
> Nicolas Pitre <nico@marvell.com>. Many thanks to Nicolas Pitre.
>
> Signed-off-by: Rahul Tank <rahult@marvell.com>
> Signed-off-by: Bing Zhao <bzhao@marvell.com>
> ---
> drivers/bluetooth/Kconfig | 2 +
> drivers/bluetooth/Makefile | 2 +
> drivers/bluetooth/bt_mrvl/Kconfig | 12 +
> drivers/bluetooth/bt_mrvl/Makefile | 7 +
> drivers/bluetooth/bt_mrvl/btm_drv.h | 223 +++++++++++
> drivers/bluetooth/bt_mrvl/btm_main.c | 728 ++++++++++++++++++++++++++++++++++
> 6 files changed, 974 insertions(+), 0 deletions(-)
> create mode 100644 drivers/bluetooth/bt_mrvl/Kconfig
> create mode 100644 drivers/bluetooth/bt_mrvl/Makefile
> create mode 100644 drivers/bluetooth/bt_mrvl/btm_drv.h
> create mode 100644 drivers/bluetooth/bt_mrvl/btm_main.c
the first thing that I need from you is to remove this vendor specific
debug mess. You can use dynamic debug and hex dump infrastructure
already present in the upstream kernel.
For the driver name please do btmrvl.ko and btmrvl_sdio.ko or use the
chipset specific code number. And I prefer not to have it in a
subdirectory. So just prefix all your files with btmrvl_
Then please resend them and I do a detailed review.
Regards
Marcel
prev parent reply other threads:[~2009-05-21 0:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 0:35 [PATCH 1/4] bluetooth: add bt_mrvl driver to support Marvell bluetooth devices Bing Zhao
2009-05-21 0:35 ` [PATCH 2/4] bluetooth: bt_mrvl_sdio: Marvell BT-over-SDIO driver Bing Zhao
2009-05-21 0:35 ` [PATCH 3/4] bluetooth: Add debugfs support to bt_mrvl driver Bing Zhao
2009-05-21 0:35 ` [PATCH 4/4] bluetooth: Documentation for Marvell Bluetooth driver Bing Zhao
2009-05-21 0:45 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242866754.3147.81.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=bzhao@marvell.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox