public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/4 v2] bluetooth: add btmrvl driver to support Marvell bluetooth devices
Date: Sat, 30 May 2009 09:09:20 +0200	[thread overview]
Message-ID: <1243667360.3523.28.camel@localhost.localdomain> (raw)
In-Reply-To: <1243640590-31666-1-git-send-email-bzhao@marvell.com>

Hi Bing,

> This driver provides basic definitions and library functions to
> support Marvell Bluetooth enabled devices, such as 88W8688 WLAN/BT
> combo chip.

we still have to talk about the handling of vendor commands. Handling
these inside the driver is a bad idea. We can just let the core forward
them to you if you are interested. I have to think about it a little
bit.

> +struct btm_thread {
> +	struct task_struct *task;
> +	wait_queue_head_t wait_q;
> +	void *priv;
> +};

Please prefix everything with btmrvl_* for cleaner namespace. Especially
for the exported symbol it is important that you have a clean namespace.

Regards

Marcel



  parent reply	other threads:[~2009-05-30  7:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-29 23:43 [PATCH 1/4 v2] bluetooth: add btmrvl driver to support Marvell bluetooth devices Bing Zhao
2009-05-29 23:43 ` [PATCH 2/4 v2] bluetooth: btmrvl_sdio: Marvell BT-over-SDIO driver Bing Zhao
2009-05-29 23:43 ` [PATCH 3/4 v2] bluetooth: Add debugfs support to btmrvl driver Bing Zhao
2009-05-29 23:43 ` [PATCH 4/4 v2] bluetooth: Documentation for Marvell Bluetooth driver Bing Zhao
2009-05-30  7:09 ` Marcel Holtmann [this message]
2009-06-02 19:05   ` [PATCH 1/4 v2] bluetooth: add btmrvl driver to support Marvell bluetooth devices Bing Zhao
2009-06-02 20:21     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243667360.3523.28.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=bzhao@marvell.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox