public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Add sixaxis cable-pairing plugin
Date: Fri, 05 Jun 2009 15:06:31 +0200	[thread overview]
Message-ID: <1244207191.23850.12.camel@localhost.localdomain> (raw)
In-Reply-To: <1244198560.30768.2403.camel@cookie.hadess.net>

Hi Bastien,

> > > Works for me, comments welcome.
> > > 
> > > It uses gudev. See http://blog.fubar.dk/?p=106
> > 
> > no way. Please use just plain libudev and spare use the GObject
> > overhead. I have used libudev before and it is just fine. Not that I
> > have actually looked at your patch at all.
> 
> GObject overhead? Did you intend on building sixaxis support into a 5
> year old phone that it would actually matter?

as I said, I am not adding a dependency on a GObject based library to
it. We wanna be able to replace GLib with eglib or similar if we have
to. Doing this for GObject based libraries is a pain in the ass. It is
just bloat.

> Anyway, that'll go way down my list of things to do, along with porting
> the rest of the apps to libusb1, which I guess will be a problem as
> well.

My biggest problem with libusb1 is that not all distros have it right
now. However that might change in 2 or 3 month. So it should become
easier.

> gudev lives in udev-extras, and udev-extras will most likely be merged
> into udev itself. And it saves me from reinventing the wheel, and doing
> my own mainloop integration (etc.).

The whole point of udev and udev-extras is to keep the dependency chain
small. So I don't think it gets merged.

The GLib mainloop integration for libudev is really simple. So that is
not an excuse for being lazy and dragging GObject into the mix.

Regards

Marcel



  reply	other threads:[~2009-06-05 13:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-04  9:28 [PATCH] Add sixaxis cable-pairing plugin Bastien Nocera
2009-06-04 18:13 ` Marcel Holtmann
2009-06-05 10:42   ` Bastien Nocera
2009-06-05 13:06     ` Marcel Holtmann [this message]
2009-06-05 13:52       ` Bastien Nocera
2009-06-05 14:15         ` Marcel Holtmann
2009-06-05 14:48           ` Bastien Nocera
2009-06-05 14:56             ` Marcel Holtmann
2009-06-05 15:06               ` Bastien Nocera
2009-06-06 17:41                 ` Luiz Augusto von Dentz
2009-06-06 17:51                   ` Marcel Holtmann
  -- strict thread matches above, loose matches on Subject: below --
2009-10-09 13:19 Bastien Nocera
2009-10-11  9:40 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244207191.23850.12.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=hadess@hadess.net \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox