public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Filippo Giunchedi <filippo@esaurito.net>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] make test/agent.c use new API
Date: Sun, 07 Jun 2009 10:42:30 +0200	[thread overview]
Message-ID: <1244364150.23850.80.camel@localhost.localdomain> (raw)
In-Reply-To: <20090607081101.GA30589@esaurito.net>

Hi Filippo,

> I've fixed the space vs tab usage, sorry.
> I'm not sure how to handle this case:
> 
> -	if (dbus_message_is_method_call(msg, "org.bluez.Agent", "Request"))
> +	if (dbus_message_is_method_call(msg, "org.bluez.Agent", "RequestPinCode") ||
> +			dbus_message_is_method_call(msg, "org.bluez.Agent",
> +								"RequestPasskey"))
> 
> with proper indentation but not going over 80 columns, that's what I came up
> with, hope that's ok.

it is not, because you need to split them into two functions anyway. One
returns a string, the other a uint32. Please read agent-api.txt.

Regards

Marcel



  reply	other threads:[~2009-06-07  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-06 20:34 [PATCH] update test/agent.c API usage Filippo Giunchedi
2009-06-06 23:18 ` Marcel Holtmann
2009-06-07  8:11   ` [PATCH] make test/agent.c use new API Filippo Giunchedi
2009-06-07  8:42     ` Marcel Holtmann [this message]
2009-06-07 10:14       ` [PATCH] test/agent.c: update dbus API usage Filippo Giunchedi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244364150.23850.80.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=filippo@esaurito.net \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox