public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/4 v3] bluetooth: add btmrvl driver to support Marvell bluetooth devices
Date: Tue, 09 Jun 2009 17:20:07 +0200	[thread overview]
Message-ID: <1244560807.3068.12.camel@localhost.localdomain> (raw)
In-Reply-To: <1243978178-3403-1-git-send-email-bzhao@marvell.com>

Hi Bing,

> This driver provides basic definitions and library functions to
> support Marvell Bluetooth enabled devices, such as 88W8688 WLAN/BT
> combo chip.

so I created a bluetooth-mrvl-2.6 tree with your patches and already a
major collection of cleanup patches.

The biggest problem right now is that your driver spits out casting
warnings like crazy. This is not acceptable. So please send me a patch
to fix these based on bluetooth-mrvl-2.6.

I did fix the firmware non-sense you had in there, but I haven't had
time to test it with real hardware. So please do so.

Also I am considering to just remove all this Enter/Leave debug
non-sense since it makes the code really hard to read.

Regards

Marcel



  parent reply	other threads:[~2009-06-09 15:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02 21:29 [PATCH 1/4 v3] bluetooth: add btmrvl driver to support Marvell bluetooth devices Bing Zhao
2009-06-02 21:29 ` [PATCH 2/4 v3] bluetooth: btmrvl_sdio: Marvell BT-over-SDIO driver Bing Zhao
2009-06-02 21:29 ` [PATCH 3/4 v3] bluetooth: Add debugfs support to btmrvl driver Bing Zhao
2009-06-02 21:29 ` [PATCH 4/4 v3] bluetooth: Documentation for Marvell Bluetooth driver Bing Zhao
2009-06-09 15:20 ` Marcel Holtmann [this message]
2009-06-09 23:39   ` [PATCH 1/4 v3] bluetooth: add btmrvl driver to support Marvell bluetooth devices Bing Zhao
2009-06-10  7:07     ` Marcel Holtmann
2009-06-10 21:18       ` Bing Zhao
2009-06-13  6:24         ` Marcel Holtmann
2009-06-16  0:02           ` Bing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244560807.3068.12.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=bzhao@marvell.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox