Re: [PATCH] Bluetooth: Improve the throughput by increasing the frame size.

[Marcel Holtmann <marcel@holtmann.org>]

Hi Vikram,

> This patch increases the receive buffer size to HCI_MAX_FRAME_SIZE
> which improves the Rx throughput considerably.
> 
> Signed-off-by: Vikram Kandukuri <Vikram.Kandukuri@atheros.com>
> ---
>  drivers/bluetooth/btusb.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index e70c57e..124db8c 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -301,7 +301,7 @@ static int btusb_submit_bulk_urb(struct hci_dev *hdev, gfp_t mem_flags)
>  	struct urb *urb;
>  	unsigned char *buf;
>  	unsigned int pipe;
> -	int err, size;
> +	int err, size = HCI_MAX_FRAME_SIZE;
>  
>  	BT_DBG("%s", hdev->name);
>  
> @@ -312,8 +312,6 @@ static int btusb_submit_bulk_urb(struct hci_dev *hdev, gfp_t mem_flags)
>  	if (!urb)
>  		return -ENOMEM;
>  
> -	size = le16_to_cpu(data->bulk_rx_ep->wMaxPacketSize);
> -

and we can ignore the wMaxPacketSize because. It would be nice to get a
reason here and that this has been tested at least with a handful of
devices.

Regards

Marcel