public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Vikram Kandukuri <vkandukuri@atheros.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Kill session whenever VIRTUAL_CABLE_UNPLUG is passed.
Date: Fri, 19 Jun 2009 11:36:02 +0200	[thread overview]
Message-ID: <1245404162.15367.44.camel@violet> (raw)
In-Reply-To: <20090620061927.GC9947@atheros-laptop>

Hi Vikram,

> Whenever the remote device sends VIRTUAL CABLE UNPLUG, the device should
> be disconnected.
> 
> Signed-off-by: Jothikumar Mothilal <jothikumar.mothilal@atheros.com>
> ---
>  net/bluetooth/hidp/core.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
> index b186768..a9f7afb 100644
> --- a/net/bluetooth/hidp/core.c
> +++ b/net/bluetooth/hidp/core.c
> @@ -374,6 +374,7 @@ static void hidp_process_hid_control(struct hidp_session *session,
>  
>  		/* Kill session thread */
>  		atomic_inc(&session->terminate);
> +		hidp_schedule(session);
>  	}
>  }

the patch is correct, but the commit message could be a little bit more
verbose. It should explain why this fixes it.

Regards

Marcel



  reply	other threads:[~2009-06-19  9:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-20  6:19 [PATCH] Bluetooth: Kill session whenever VIRTUAL_CABLE_UNPLUG is passed Vikram Kandukuri
2009-06-19  9:36 ` Marcel Holtmann [this message]
2009-06-25  7:26   ` Jothikumar Mothilal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245404162.15367.44.camel@violet \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=vkandukuri@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox