Re: [PATCH] Add support for registration of a PBAP service using sdptool

Bastien Nocera
2009-06-26T08:43:14Z

On Fri, 2009-06-26 at 09:01 +0200, Marcel Holtmann wrote:
> Ni Nick,
>
> > From: Jiafa Liu <pbx376@motorola.com>
> >
> > ---
> > tools/sdptool.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > 1 files changed, 80 insertions(+), 1 deletions(-)
>
> argh :(
>
> gcc -DHAVE_CONFIG_H -I. -I.. -I../common -I../include -Wall -O2 -D_FORTIFY_SOURCE=2 -Werror -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wdeclaration-after-statement -Wmissing-declarations -Wredundant-decls -Wcast-align -D_FORTIFY_SOURCE=2 -fPIC -g -O0 -MT sdptool.o -MD -MP -MF .deps/sdptool.Tpo -c -o sdptool.o sdptool.c
> cc1: warnings being treated as errors
> sdptool.c: In function ‘add_pbap’:
> sdptool.c:1873: error: comparison between signed and unsigned integer expressions
>
> Can we at least try to compile it with ./bootstrap-configure and all our
> warnings enabled.
>
> I fixed it now, but come on that is not too much to ask.

You'd be right if it wasn't bogus, and GCC being anal...