From: Marcel Holtmann <marcel@holtmann.org>
To: Nick Pelly <npelly@google.com>
Cc: linux-bluetooth@vger.kernel.org, Jiafa Liu <pbx376@motorola.com>
Subject: Re: [PATCH] Add support for registration of a PBAP service using sdptool
Date: Fri, 26 Jun 2009 09:01:54 +0200 [thread overview]
Message-ID: <1245999714.12994.103.camel@localhost.localdomain> (raw)
In-Reply-To: <1245976084-8936-1-git-send-email-npelly@google.com>
Ni Nick,
> From: Jiafa Liu <pbx376@motorola.com>
>
> ---
> tools/sdptool.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 80 insertions(+), 1 deletions(-)
argh :(
gcc -DHAVE_CONFIG_H -I. -I.. -I../common -I../include -Wall -O2 -D_FORTIFY_SOURCE=2 -Werror -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wdeclaration-after-statement -Wmissing-declarations -Wredundant-decls -Wcast-align -D_FORTIFY_SOURCE=2 -fPIC -g -O0 -MT sdptool.o -MD -MP -MF .deps/sdptool.Tpo -c -o sdptool.o sdptool.c
cc1: warnings being treated as errors
sdptool.c: In function ‘add_pbap’:
sdptool.c:1873: error: comparison between signed and unsigned integer expressions
Can we at least try to compile it with ./bootstrap-configure and all our
warnings enabled.
I fixed it now, but come on that is not too much to ask.
Regards
Marcel
next prev parent reply other threads:[~2009-06-26 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 0:28 [PATCH] Add support for registration of a PBAP service using sdptool Nick Pelly
2009-06-26 7:01 ` Marcel Holtmann [this message]
2009-06-26 8:43 ` Bastien Nocera
2009-06-26 9:42 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245999714.12994.103.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=npelly@google.com \
--cc=pbx376@motorola.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox