Re: [PATCH] Add udev rules to start bluetooth on-demand

[Bastien Nocera <hadess@hadess.net>]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

On Sat, 2009-06-27 at 12:27 +0200, Marcel Holtmann wrote:
> Hi Bastien,
> 
> > > > > > > > > > As discussed in previous mails.
> > > > > > > > > 
> > > > > > > > > please name it bluetooth.rules. The daemon is also called bluetoothd and
> > > > > > > > > not bluezd.
> > > > > > > > > 
> > > > > > > > > Also you need to have the EXTRA_DIST part in it since _DATA doesn't get
> > > > > > > > > added to the distribution automatically. For all this changes, you have
> > > > > > > > > to check with make distcheck.
> > > > > > > > 
> > > > > > > > Fixed version attached
> > > > > > > 
> > > > > > > we might need to put this into ifndef INITSCRIPTS since it makes no
> > > > > > > sense to install the init script and the udev rule at the same time.
> > > > > > 
> > > > > > Revised patch attached
> > > > > 
> > > > > +
> > > > > +if INISCRIPTS
> > > > > +else
> > > > > +rules_DATA += bluetooth.rules
> > > > >  endif
> > > > 
> > > > ifndef isn't an automake construct.
> > > > 
> > > 
> > > then if !INITSCRIPTS should do it. However I was more asking about the
> > > spelling mistake. You forgot a T ;)
> > 
> > Well, that's embarrassing...
> 
> are you sending a new patch :)

Thought you'd fix the typo, and commit.

Patch attached.

[-- Attachment #2: 0001-Add-udev-rules-to-start-bluetooth-on-demand.patch --]
[-- Type: text/x-patch, Size: 1062 bytes --]

>From 9602419da57953b91e4fcb7a6e3770744154dbef Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@hadess.net>
Date: Mon, 29 Jun 2009 15:54:46 +0100
Subject: [PATCH] Add udev rules to start bluetooth on-demand

Those rules call bluetoothd --udev when a new dongle is inserted.
---
 scripts/Makefile.am |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/scripts/Makefile.am b/scripts/Makefile.am
index 494a9c2..d97b309 100644
--- a/scripts/Makefile.am
+++ b/scripts/Makefile.am
@@ -11,6 +11,10 @@ endif
 if PCMCIARULES
 rules_DATA += bluetooth-serial.rules
 endif
+
+if INITSCRIPTS
+else
+rules_DATA += bluetooth.rules
 endif
 
 if PCMCIARULES
@@ -19,8 +23,13 @@ udevdir = $(libexecdir)/udev
 udev_SCRIPTS = bluetooth_serial
 endif
 
+if INITSCRIPTS
+else
+rules_DATA += bluetooth.rules
+endif
+
 EXTRA_DIST = bluetooth.init bluetooth.default bluetooth-hid2hci.rules \
-				bluetooth-serial.rules bluetooth_serial
+				bluetooth-serial.rules bluetooth_serial bluetooth.rules
 
 MAINTAINERCLEANFILES = Makefile.in
 
-- 
1.6.2.2