From: Marcel Holtmann <marcel@holtmann.org>
To: Jaikumar Ganesh <jaikumar@google.com>
Cc: linux-bluetooth@vger.kernel.org, Zhu Lan <mtcb47@motorola.com>
Subject: Re: [PATCH] Modify PBAP SDP record.
Date: Thu, 06 Aug 2009 13:09:41 -0700 [thread overview]
Message-ID: <1249589381.21101.22.camel@localhost.localdomain> (raw)
In-Reply-To: <1249588984-9043-1-git-send-email-jaikumar@google.com>
Hi Jaikumar,
> Fix to pass PTS case TC_SDAS_BV_03_I(since PTS3.2 update2).
> The code tried to append the UINT type value to the supported
> respositories. However, the wrong function sdp_seq_alloc()
> was used. This function adds 2 redundant bytes (SDP_SEQ8 as
> 0x35, seq) ahead of 0x08, so that latest PTS IOPT will fail.
> According to spec, PBAP attributes should report 0x08 0x01
> or 0x08 0x03 right after 0x0314. The correct function to use
> is sdp_data_alloc(), with clean 0x08 0x01 appended as
> SDP_ATTR_SUPPORTED_REPOSITORIES.
> ---
> tools/sdptool.c | 9 ++-------
> 1 files changed, 2 insertions(+), 7 deletions(-)
can I get a version of this patch that applies cleanly when using git am
please.
Regards
Marcel
next prev parent reply other threads:[~2009-08-06 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 20:03 [PATCH] Modify PBAP SDP record Jaikumar Ganesh
2009-08-06 20:09 ` Marcel Holtmann [this message]
2009-08-06 21:00 ` Jaikumar Ganesh
2009-08-06 21:12 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249589381.21101.22.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=jaikumar@google.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mtcb47@motorola.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox