From: Marcel Holtmann <marcel@holtmann.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: Nick Pelly <npelly@google.com>,
linux-bluetooth@vger.kernel.org,
Jaikumar Ganesh <jaikumar@google.com>
Subject: Re: [PATCH] Fix audio.conf parsing bug - sink and source were transposed.
Date: Sat, 22 Aug 2009 13:06:45 -0700 [thread overview]
Message-ID: <1250971605.2950.27.camel@localhost.localdomain> (raw)
In-Reply-To: <1250636912.12900.111.camel@localhost.localdomain>
Hi Bastien,
> > Jaikumar just gave me the heads up that this is by design.
> >
> > Enable=Sink means that bluetoothd offers the Sink interface for remote
> > devices - and that we are a source.
> > Enable=Source means that bluetoothd offers the Source interface for
> > remote devices - and that we are a sink.
> >
> > I'd say its counter-intuitive, but we can live with it.
>
> Comments in the code could fix that?
I prefer that we add comments in the code and the configuration file.
Nick, please send a patch that adds these comments.
Regards
Marcel
prev parent reply other threads:[~2009-08-22 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 22:32 [PATCH] Fix audio.conf parsing bug - sink and source were transposed Nick Pelly
2009-08-18 23:01 ` Nick Pelly
2009-08-18 23:08 ` Bastien Nocera
2009-08-22 20:06 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250971605.2950.27.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=hadess@hadess.net \
--cc=jaikumar@google.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=npelly@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox