From: Marcel Holtmann <marcel@holtmann.org>
To: "Weng, Wending" <WWeng@rheinmetall.ca>
Cc: "'linux-bluetooth@vger.kernel.org'" <linux-bluetooth@vger.kernel.org>
Subject: RE: patch for hci_bcsp.c(2.6.31.-rc1)
Date: Mon, 24 Aug 2009 10:19:26 -0700 [thread overview]
Message-ID: <1251134366.2950.54.camel@localhost.localdomain> (raw)
In-Reply-To: <54B31811B83D744D90BF0289EB447D460C1A5045@MAIL-MB1.oerlikon.ca>
Hi Wending,
please don't top post. Use proper inline quoting.
> If I keep "if (i++ >= pkts_to_be_removed)", the loop will end up with
> i=2 if pkts_to_be_removed==1 and the second test skb_queue_walk_safe is true,
>
> it will cause error message later on:
>
> if (i != pkts_to_be_removed) {
> BT_ERR("Removed only %u out of %u pkts", i, pkts_to_be_removed);
> }
>
> I think we should add another line for i++.
Not following? I am saying replace >= with >. Would that work too?
Otherwise please send a patch with a more detailed commit message.
Regards
Marcel
next prev parent reply other threads:[~2009-08-24 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 13:19 patch for hci_bcsp.c(2.6.31.-rc1) Weng, Wending
2009-08-22 20:05 ` Marcel Holtmann
2009-08-24 14:03 ` Weng, Wending
2009-08-24 17:19 ` Marcel Holtmann [this message]
2009-08-24 18:33 ` Weng, Wending
2009-08-24 18:37 ` Marcel Holtmann
2009-08-24 20:19 ` patch for hci_bcsp.c(bluetooth-testing) Weng, Wending
2009-08-24 20:34 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251134366.2950.54.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=WWeng@rheinmetall.ca \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox